Re: [Xen-devel] [PATCH 19/27] tools/libxc+libxl+xl: Restore v2 streams

2015-06-16 Thread Ian Campbell
On Tue, 2015-06-16 at 16:23 +0100, Andrew Cooper wrote: > I am half tempted to say that anyone experiencing 32->64bit problems > should just use the conversion helper themselves. It is deliberately > written to be usable on the command line as well as automatically. Yes, I think that's a good pla

Re: [Xen-devel] [PATCH 19/27] tools/libxc+libxl+xl: Restore v2 streams

2015-06-16 Thread Andrew Cooper
On 16/06/15 15:53, Ian Campbell wrote: > On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote: >> @@ -377,6 +384,28 @@ static void record_body_done(libxl__egc *egc, >> stream_failed(egc, stream, ret); >> } >> >> +void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void, >> +

Re: [Xen-devel] [PATCH 19/27] tools/libxc+libxl+xl: Restore v2 streams

2015-06-16 Thread Ian Campbell
On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote: > @@ -377,6 +384,28 @@ static void record_body_done(libxl__egc *egc, > stream_failed(egc, stream, ret); > } > > +void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void, > + int ret, int ret

[Xen-devel] [PATCH 19/27] tools/libxc+libxl+xl: Restore v2 streams

2015-06-15 Thread Andrew Cooper
This is a complicated set of changes which must be done together for bisectability. * libxl-save-helper is updated to unconditionally use libxc migration v2. * libxl compatibility workarounds in libxc are disabled for restore operations. * libxl__stream_read_start() is logically spliced into th