Re: [Xen-devel] [PATCH 13/19] xen: credit2: make the code less experimental

2016-07-07 Thread Dario Faggioli
On Thu, 2016-07-07 at 16:17 +0100, George Dunlap wrote: > On Sat, Jun 18, 2016 at 12:12 AM, Dario Faggioli > wrote: > > @@ -680,8 +677,8 @@ __update_svc_load(const struct scheduler *ops, > >  delta = now - svc->load_last_update; > >  if ( unlikely(delta < 0) ) > >  { > > - 

Re: [Xen-devel] [PATCH 13/19] xen: credit2: make the code less experimental

2016-07-07 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:12 AM, Dario Faggioli wrote: > Mainly, almost all of the BUG_ON-s can be converted into > ASSERTS, and the debug printk either removed or turned > into tracing. > > The 'TODO' list, in a comment at the beginning of the file, > was also stale, so remove items that were st

Re: [Xen-devel] [PATCH 13/19] xen: credit2: make the code less experimental

2016-07-07 Thread Dario Faggioli
On Mon, 2016-06-20 at 02:13 -0600, Jan Beulich wrote: > > > > On 18.06.16 at 01:12, wrote: > > @@ -680,8 +677,8 @@ __update_svc_load(const struct scheduler *ops, > >  delta = now - svc->load_last_update; > >  if ( unlikely(delta < 0) ) > >  { > > -d2printk("%s:

Re: [Xen-devel] [PATCH 13/19] xen: credit2: make the code less experimental

2016-06-20 Thread Jan Beulich
>>> On 18.06.16 at 01:12, wrote: > @@ -608,8 +605,8 @@ __update_runq_load(const struct scheduler *ops, > delta = now - rqd->load_last_update; > if ( unlikely(delta < 0) ) > { > -d2printk("%s: Time went backwards? now %"PRI_stime" llu > %"PRI_stime"\n", > -

[Xen-devel] [PATCH 13/19] xen: credit2: make the code less experimental

2016-06-17 Thread Dario Faggioli
Mainly, almost all of the BUG_ON-s can be converted into ASSERTS, and the debug printk either removed or turned into tracing. The 'TODO' list, in a comment at the beginning of the file, was also stale, so remove items that were still there but are actually done. Signed-off-by: Dario Faggioli ---