Re: [Xen-devel] [PATCH 1/7] x86/traps: Drop 32bit fields out of tss_struct

2017-05-03 Thread Andrew Cooper
On 03/05/17 09:10, Jan Beulich wrote: On 02.05.17 at 20:05, wrote: >> The backlink field doesn't exist in a 64bit TSS, and union for esp{0..2} is >> of >> no practical use. Specify everything with stdint types, and empty bitfields >> for reserved values. >> >> No functional change. >> >> Si

Re: [Xen-devel] [PATCH 1/7] x86/traps: Drop 32bit fields out of tss_struct

2017-05-03 Thread Wei Liu
On Tue, May 02, 2017 at 07:05:20PM +0100, Andrew Cooper wrote: > The backlink field doesn't exist in a 64bit TSS, and union for esp{0..2} is of > no practical use. Specify everything with stdint types, and empty bitfields > for reserved values. > > No functional change. > > Signed-off-by: Andrew

Re: [Xen-devel] [PATCH 1/7] x86/traps: Drop 32bit fields out of tss_struct

2017-05-03 Thread Jan Beulich
>>> On 02.05.17 at 20:05, wrote: > The backlink field doesn't exist in a 64bit TSS, and union for esp{0..2} is of > no practical use. Specify everything with stdint types, and empty bitfields > for reserved values. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Be

[Xen-devel] [PATCH 1/7] x86/traps: Drop 32bit fields out of tss_struct

2017-05-02 Thread Andrew Cooper
The backlink field doesn't exist in a 64bit TSS, and union for esp{0..2} is of no practical use. Specify everything with stdint types, and empty bitfields for reserved values. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/traps.c| 2 +- x