Re: [Xen-devel] [PATCH 1/5] x86/hvm: Rework HVM_HCALL_invalidate handling

2017-02-13 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Monday, February 13, 2017 9:04 PM > > Sending an invalidation to the device model is an internal detail of > completing the hypercall; callers should not need to be responsible for it. > Drop HVM_HCALL_invalidate entirely and call se

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Rework HVM_HCALL_invalidate handling

2017-02-13 Thread Jan Beulich
>>> On 13.02.17 at 18:01, wrote: > On 13/02/17 16:49, Jan Beulich wrote: > On 13.02.17 at 14:03, wrote: >>> Sending an invalidation to the device model is an internal detail of >>> completing the hypercall; callers should not need to be responsible for it. >>> Drop HVM_HCALL_invalidate entire

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Rework HVM_HCALL_invalidate handling

2017-02-13 Thread Andrew Cooper
On 13/02/17 16:49, Jan Beulich wrote: On 13.02.17 at 14:03, wrote: >> Sending an invalidation to the device model is an internal detail of >> completing the hypercall; callers should not need to be responsible for it. >> Drop HVM_HCALL_invalidate entirely and call send_invalidate_req() when >

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Rework HVM_HCALL_invalidate handling

2017-02-13 Thread Jan Beulich
>>> On 13.02.17 at 14:03, wrote: > Sending an invalidation to the device model is an internal detail of > completing the hypercall; callers should not need to be responsible for it. > Drop HVM_HCALL_invalidate entirely and call send_invalidate_req() when > appropriate. > > This makes the function

Re: [Xen-devel] [PATCH 1/5] x86/hvm: Rework HVM_HCALL_invalidate handling

2017-02-13 Thread Boris Ostrovsky
On 02/13/2017 08:03 AM, Andrew Cooper wrote: Sending an invalidation to the device model is an internal detail of completing the hypercall; callers should not need to be responsible for it. Drop HVM_HCALL_invalidate entirely and call send_invalidate_req() when appropriate. This makes the funct

[Xen-devel] [PATCH 1/5] x86/hvm: Rework HVM_HCALL_invalidate handling

2017-02-13 Thread Andrew Cooper
Sending an invalidation to the device model is an internal detail of completing the hypercall; callers should not need to be responsible for it. Drop HVM_HCALL_invalidate entirely and call send_invalidate_req() when appropriate. This makes the function boolean in nature, although the existing HVM_