Re: [Xen-devel] [PATCH 1/5] VMX: dump full guest state

2015-01-22 Thread Jan Beulich
>>> On 22.01.15 at 05:40, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, January 20, 2015 7:06 PM >> >> Several guest state fields did not get dumped so far. Where suitable >> (to reduce the amount of output) make some of the dumping conditional >> upon guest settings (

Re: [Xen-devel] [PATCH 1/5] VMX: dump full guest state

2015-01-21 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, January 20, 2015 7:06 PM > > Several guest state fields did not get dumped so far. Where suitable > (to reduce the amount of output) make some of the dumping conditional > upon guest settings (this isn't required for correctness as vm

Re: [Xen-devel] [PATCH 1/5] VMX: dump full guest state

2015-01-21 Thread Jan Beulich
>>> On 20.01.15 at 18:03, wrote: > On 20/01/15 11:05, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/vmx/vmcs.c >> +++ b/xen/arch/x86/hvm/vmx/vmcs.c >> @@ -1395,6 +1395,16 @@ static inline unsigned long vmr(unsigned >> return __vmread_safe(field, &val) ? val : 0; >> } >> >> +#define vmr16(fl

Re: [Xen-devel] [PATCH 1/5] VMX: dump full guest state

2015-01-20 Thread Andrew Cooper
On 20/01/15 11:05, Jan Beulich wrote: > Several guest state fields did not get dumped so far. Where suitable > (to reduce the amount of output) make some of the dumping conditional > upon guest settings (this isn't required for correctness as vmr() > already uses __vmread_safe(), i.e. it is fine to

[Xen-devel] [PATCH 1/5] VMX: dump full guest state

2015-01-20 Thread Jan Beulich
Several guest state fields did not get dumped so far. Where suitable (to reduce the amount of output) make some of the dumping conditional upon guest settings (this isn't required for correctness as vmr() already uses __vmread_safe(), i.e. it is fine to access non-existing fields). Move CR3_TARGET