Andrew Cooper writes ("Re: [Xen-devel] [PATCH 1/4] libxl: convert to use LOG()
macro"):
> There are a number of entries like this where the number of lines could
> be reduced.
Indeed, but that's IMO no reason to block this patch which is a big
improvement.
> > -
On Tue, Sep 15, 2015 at 04:12:57PM +0100, Andrew Cooper wrote:
> On 15/09/15 10:41, Wei Liu wrote:
> > @@ -440,15 +436,18 @@ int libxl__domain_rename(libxl__gc *gc, uint32_t
> > domid,
> > if (old_name) {
> > got_old_name = xs_read(ctx->xsh, trans, name_path, &got_old_len);
> >
On 15/09/15 10:41, Wei Liu wrote:
> @@ -440,15 +436,18 @@ int libxl__domain_rename(libxl__gc *gc, uint32_t domid,
> if (old_name) {
> got_old_name = xs_read(ctx->xsh, trans, name_path, &got_old_len);
> if (!got_old_name) {
> -LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ER
This patch converts most LIBXL__LOG* macros to LOG macro. It's done with
spatch plus some hand coding.
Using spatch rune:
spatch --in-place --no-includes --include-headers \
--sp-file libxl.spatch \
tools/libxl/libxl*.c
with some exceptions.
libxl_json.c is untouched because
