>>> On 15.06.15 at 19:14, wrote:
> Personally, I would go a step further and suggest that if a macro is not
> doing {string,token}isation, or deliberately playing with local state,
> it should be a static inline function instead (although I do appear to
> be in the minority with this view).
>
> T
>>> On 15.06.15 at 18:09, wrote:
> On Mon, 15 Jun 2015 16:23:13 +0100 Jan Beulich wrote:
>> >>> On 15.06.15 at 16:35, wrote:
>> > On 15/06/15 15:30, Don Slutz wrote:
>> >> On 06/15/15 10:19, Andrew Cooper wrote:
>> >>> Furthermore, what about devfn or reg?
>> >>>
>> >> devfn and reg do not need t
On 15/06/15 17:09, Mihai Donțu wrote:
> On Mon, 15 Jun 2015 16:23:13 +0100 Jan Beulich wrote:
> On 15.06.15 at 16:35, wrote:
>>> On 15/06/15 15:30, Don Slutz wrote:
On 06/15/15 10:19, Andrew Cooper wrote:
> Furthermore, what about devfn or reg?
>
devfn and reg do not need the
On Mon, 15 Jun 2015 16:23:13 +0100 Jan Beulich wrote:
> >>> On 15.06.15 at 16:35, wrote:
> > On 15/06/15 15:30, Don Slutz wrote:
> >> On 06/15/15 10:19, Andrew Cooper wrote:
> >>> Furthermore, what about devfn or reg?
> >>>
> >> devfn and reg do not need the bracketing since they are just passed,
>>> On 15.06.15 at 16:35, wrote:
> On 15/06/15 15:30, Don Slutz wrote:
>> On 06/15/15 10:19, Andrew Cooper wrote:
>>> Furthermore, what about devfn or reg?
>>>
>> devfn and reg do not need the bracketing since they are just passed,
>> but I have no issue with adding the extra brackets.
>
> Macros
>>> On 15.06.15 at 16:30, wrote:
> On 06/15/15 10:19, Andrew Cooper wrote:
>> On 15/06/15 15:15, Don Slutz wrote:
>>> Signed-off-by: Don Slutz
>>> CC: Don Slutz
>>
>> Fix how? It looks like you are bracketing val.
>>
>
> If val is an expression, the macro most likely does the wrong thing.
>
On 15/06/15 15:30, Don Slutz wrote:
> On 06/15/15 10:19, Andrew Cooper wrote:
>> On 15/06/15 15:15, Don Slutz wrote:
>>> Signed-off-by: Don Slutz
>>> CC: Don Slutz
>> Fix how? It looks like you are bracketing val.
>>
> If val is an expression, the macro most likely does the wrong thing.
>
> For
>>> On 15.06.15 at 16:19, wrote:
> On 15/06/15 15:15, Don Slutz wrote:
>> Signed-off-by: Don Slutz
>> CC: Don Slutz
>
> Fix how? It looks like you are bracketing val.
>
> This is an improvement, but please always be specific as to what is
> being fixed.
>
> Furthermore, what about devfn or r
On 06/15/15 10:19, Andrew Cooper wrote:
> On 15/06/15 15:15, Don Slutz wrote:
>> Signed-off-by: Don Slutz
>> CC: Don Slutz
>
> Fix how? It looks like you are bracketing val.
>
If val is an expression, the macro most likely does the wrong thing.
For example:
pci_writeb(devfn, PCI_IO_BASE, ad
On 15/06/15 15:15, Don Slutz wrote:
> Signed-off-by: Don Slutz
> CC: Don Slutz
Fix how? It looks like you are bracketing val.
This is an improvement, but please always be specific as to what is
being fixed.
Furthermore, what about devfn or reg?
~Andrew
> ---
> tools/firmware/hvmloader/util
Signed-off-by: Don Slutz
CC: Don Slutz
---
tools/firmware/hvmloader/util.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h
index a70e4aa..8431f2d 100644
--- a/tools/firmware/hvmloader/util.h
+++ b/tools/f
11 matches
Mail list logo
