Re: [Xen-devel] [PATCH 1/3] x86: streamline hypercall_create_continuation()

2015-01-08 Thread Jan Beulich
>>> On 08.01.15 at 17:01, wrote: > There appear to other many other places which could benifit from a > caching of guest_x86_mode() (especially in the nested virt case). Is it > worth considering unconditionally calculating on vmexit and removing the > function? If it's _only_ nested, then maybe

Re: [Xen-devel] [PATCH 1/3] x86: streamline hypercall_create_continuation()

2015-01-08 Thread Andrew Cooper
On 08/01/15 15:22, Jan Beulich wrote: > - drop clearing of excessive multicall arguments in compat case (no > longer needed now that hypercall_xlat_continuation() only checks the > actual arguments) > - latch current into a local variable > - use the cached value of hvm_guest_x86_mode() instead

[Xen-devel] [PATCH 1/3] x86: streamline hypercall_create_continuation()

2015-01-08 Thread Jan Beulich
- drop clearing of excessive multicall arguments in compat case (no longer needed now that hypercall_xlat_continuation() only checks the actual arguments) - latch current into a local variable - use the cached value of hvm_guest_x86_mode() instead of re-executing it - scope restrict "regs" -