On 07/20/2015 09:28 AM, Olaf Hering wrote:
On Thu, Jul 16, Jim Fehlig wrote:
@@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn,
virObjectUnref(socks[i]);
}
VIR_FREE(socks);
+virObjectUnref(args);
This is now below the 'error' label, so args has to be
On Thu, Jul 16, Jim Fehlig wrote:
> @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn,
> virObjectUnref(socks[i]);
> }
> VIR_FREE(socks);
> +virObjectUnref(args);
This is now below the 'error' label, so args has to be initialized.
[ 149s] libxl/libxl_mig
This patch fixes some flawed logic around ref counting the
libxlMigrationDstArgs object.
First, when adding sockets to the event loop with
virNetSocketAddIOCallback(), the generic virObjectFreeCallback()
was registered as a free function, with libxlMigrationDstArgs as
its parameter. A reference wa
