Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-06-24 Thread Meng Xu
On Fri, Jun 24, 2016 at 3:45 AM, Dario Faggioli wrote: > On Thu, 2016-06-23 at 11:42 +0100, George Dunlap wrote: >> On 22/06/16 17:16, Meng Xu wrote: >> > >> > I think he is trying to align those comments to make them start >> > from >> > the same column. I was confused at the reason at the very >

Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-06-24 Thread Dario Faggioli
On Thu, 2016-06-23 at 11:42 +0100, George Dunlap wrote: > On 22/06/16 17:16, Meng Xu wrote: > >  > > I think he is trying to align those comments to make them start > > from > > the same column. I was confused at the reason at the very > > beginning. > > Then I pulled his repo and checked this chan

Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-06-23 Thread George Dunlap
On 22/06/16 17:16, Meng Xu wrote: > On Wed, Jun 22, 2016 at 11:51 AM, George Dunlap > wrote: >> On Mon, May 16, 2016 at 12:54 AM, Tianyang Chen wrote: >>> No functional change: >>> -Various coding style fix >>> -Added comments for UPDATE_LIMIT_SHIFT. >>> >>> Signed-off-by: Tianyang Chen >> >>

Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-06-22 Thread Meng Xu
On Wed, Jun 22, 2016 at 11:51 AM, George Dunlap wrote: > On Mon, May 16, 2016 at 12:54 AM, Tianyang Chen wrote: >> No functional change: >> -Various coding style fix >> -Added comments for UPDATE_LIMIT_SHIFT. >> >> Signed-off-by: Tianyang Chen > > Hey Tianyang, > > The changes here for the mos

Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-06-22 Thread George Dunlap
On Mon, May 16, 2016 at 12:54 AM, Tianyang Chen wrote: > No functional change: > -Various coding style fix > -Added comments for UPDATE_LIMIT_SHIFT. > > Signed-off-by: Tianyang Chen Hey Tianyang, The changes here for the most part look good (with a few comments -- see below), but the title an

Re: [Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-05-17 Thread Meng Xu
On Sun, May 15, 2016 at 7:54 PM, Tianyang Chen wrote: > No functional change: > -Various coding style fix > -Added comments for UPDATE_LIMIT_SHIFT. > > Signed-off-by: Tianyang Chen Reviewed-by: Meng Xu --- Meng Xu PhD Student in Computer and Information Science University of Pennsylv

[Xen-devel] [PATCH 1/2] xen: sched: rtds refactor code

2016-05-15 Thread Tianyang Chen
No functional change: -Various coding style fix -Added comments for UPDATE_LIMIT_SHIFT. Signed-off-by: Tianyang Chen --- xen/common/sched_rt.c | 106 ++--- 1 file changed, 56 insertions(+), 50 deletions(-) diff --git a/xen/common/sched_rt.c b/xen/c