Re: [Xen-devel] [PATCH 1/2] x86/mm: Use mfn_t for new_guest_cr3()

2017-09-01 Thread George Dunlap
On Wed, Aug 30, 2017 at 1:19 PM, Andrew Cooper wrote: > No functional change (as confirmed by diffing the assembly). > > Signed-off-by: Andrew Cooper Acked-by: George Dunlap > --- > CC: Jan Beulich > CC: Wei Liu > > For some reason best known to GCC, there is one single change: > > @@ -14583

Re: [Xen-devel] [PATCH 1/2] x86/mm: Use mfn_t for new_guest_cr3()

2017-08-30 Thread Jan Beulich
>>> On 30.08.17 at 17:57, wrote: > On 30/08/17 16:45, Jan Beulich wrote: > On 30.08.17 at 14:19, wrote: >>> @@ -2772,23 +2772,23 @@ int vcpu_destroy_pagetables(struct vcpu *v) >>> return rc != -EINTR ? rc : -ERESTART; >>> } >>> >>> -int new_guest_cr3(unsigned long mfn) >>> +int new_gu

Re: [Xen-devel] [PATCH 1/2] x86/mm: Use mfn_t for new_guest_cr3()

2017-08-30 Thread Andrew Cooper
On 30/08/17 16:45, Jan Beulich wrote: On 30.08.17 at 14:19, wrote: >> @@ -2772,23 +2772,23 @@ int vcpu_destroy_pagetables(struct vcpu *v) >> return rc != -EINTR ? rc : -ERESTART; >> } >> >> -int new_guest_cr3(unsigned long mfn) >> +int new_guest_cr3(mfn_t mfn) >> { >> struct vcp

Re: [Xen-devel] [PATCH 1/2] x86/mm: Use mfn_t for new_guest_cr3()

2017-08-30 Thread Jan Beulich
>>> On 30.08.17 at 14:19, wrote: > @@ -2772,23 +2772,23 @@ int vcpu_destroy_pagetables(struct vcpu *v) > return rc != -EINTR ? rc : -ERESTART; > } > > -int new_guest_cr3(unsigned long mfn) > +int new_guest_cr3(mfn_t mfn) > { > struct vcpu *curr = current; > struct domain *d = cu

Re: [Xen-devel] [PATCH 1/2] x86/mm: Use mfn_t for new_guest_cr3()

2017-08-30 Thread Wei Liu
On Wed, Aug 30, 2017 at 01:19:32PM +0100, Andrew Cooper wrote: > No functional change (as confirmed by diffing the assembly). > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.o

[Xen-devel] [PATCH 1/2] x86/mm: Use mfn_t for new_guest_cr3()

2017-08-30 Thread Andrew Cooper
No functional change (as confirmed by diffing the assembly). Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu For some reason best known to GCC, there is one single change: @@ -145835,7 +145835,7 @@ 82d0802864f8: 85 c0 test %eax,%eax 82d0802864fa