Re: [Xen-devel] [PATCH 1/2] x86/domctl: cleanup

2015-04-13 Thread Andrew Cooper
On 13/04/15 15:27, Jan Beulich wrote: > >>> On 01.04.15 at 17:31, wrote: >> case XEN_DOMCTL_gettscinfo: >> -{ >> -xen_guest_tsc_info_t info; >> - >> -ret = -EINVAL; >> -if ( d == current->domain ) /* no domain_pause() */ >> -break; >> - >> -dom

Re: [Xen-devel] [PATCH 1/2] x86/domctl: cleanup

2015-04-13 Thread Jan Beulich
>>> On 01.04.15 at 17:31, wrote: > case XEN_DOMCTL_gettscinfo: > -{ > -xen_guest_tsc_info_t info; > - > -ret = -EINVAL; > -if ( d == current->domain ) /* no domain_pause() */ > -break; > - > -domain_pause(d); > -tsc_get_info(d, &info.ts

Re: [Xen-devel] [PATCH 1/2] x86/domctl: cleanup

2015-04-01 Thread Konrad Rzeszutek Wilk
On Wed, Apr 01, 2015 at 04:31:02PM +0100, Andrew Cooper wrote: > * latch curr/currd once at start > * drop redundant "ret = 0" and braces > * use "copyback = 1" when appropriate > * move break statements inside case-specific braced scopes > * don't bother check for NULL before calling xfree()

[Xen-devel] [PATCH 1/2] x86/domctl: cleanup

2015-04-01 Thread Andrew Cooper
* latch curr/currd once at start * drop redundant "ret = 0" and braces * use "copyback = 1" when appropriate * move break statements inside case-specific braced scopes * don't bother check for NULL before calling xfree() * eliminate trailing whitespace * Xen style corrections Signed-off-by: