Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-13 Thread Jan Beulich
>>> On 13.10.17 at 11:51, wrote: > On 12/10/17 21:55, Andrew Cooper wrote: >> On 12/10/2017 21:50, Doug Goldstein wrote: >>> From: David Esler >>> >>> In 9180f5365524 a change was made to the send_chr function to take in >>> C-strings and print out a character at a time until a NULL was >>> encou

Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-13 Thread Julien Grall
Hi Andrew, On 12/10/17 21:55, Andrew Cooper wrote: On 12/10/2017 21:50, Doug Goldstein wrote: From: David Esler In 9180f5365524 a change was made to the send_chr function to take in C-strings and print out a character at a time until a NULL was encountered. However there is no code to increme

Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-12 Thread Doug Goldstein
> On Oct 12, 2017, at 4:27 PM, Daniel Kiper wrote: > >> On Thu, Oct 12, 2017 at 03:50:06PM -0500, Doug Goldstein wrote: >> From: David Esler >> >> In 9180f5365524 a change was made to the send_chr function to take in >> C-strings and print out a character at a time until a NULL was >> encounte

Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-12 Thread Daniel Kiper
On Thu, Oct 12, 2017 at 03:50:06PM -0500, Doug Goldstein wrote: > From: David Esler > > In 9180f5365524 a change was made to the send_chr function to take in > C-strings and print out a character at a time until a NULL was > encountered. However there is no code to increment the current character

Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-12 Thread Andrew Cooper
On 12/10/2017 21:50, Doug Goldstein wrote: > From: David Esler > > In 9180f5365524 a change was made to the send_chr function to take in > C-strings and print out a character at a time until a NULL was > encountered. However there is no code to increment the current character > position resulting

[Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-12 Thread Doug Goldstein
From: David Esler In 9180f5365524 a change was made to the send_chr function to take in C-strings and print out a character at a time until a NULL was encountered. However there is no code to increment the current character position resulting in an endless loop of the first character. This adds a