Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-29 Thread Boris Ostrovsky
On 01/29/2015 06:46 AM, Jan Beulich wrote: On 28.01.15 at 20:56, wrote: @@ -59,6 +60,12 @@ static void __init parse_vpmu_param(char *s) } /* fall through */ case 1: +if ( opt_watchdog ) +{ +printk("NMI watchdog is enabled. Disabling VPMU\n")

Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-29 Thread Andrew Cooper
On 28/01/15 23:36, Boris Ostrovsky wrote: > On 01/28/2015 05:41 PM, Andrew Cooper wrote: >> On 28/01/2015 22:33, Boris Ostrovsky wrote: >>> On 01/28/2015 04:49 PM, Andrew Cooper wrote: On 28/01/2015 19:56, Boris Ostrovsky wrote: > NMI watchdog sets APIC_LVTPC register to generate an NMI wh

Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-29 Thread Jan Beulich
>>> On 28.01.15 at 20:56, wrote: > @@ -59,6 +60,12 @@ static void __init parse_vpmu_param(char *s) > } > /* fall through */ > case 1: > +if ( opt_watchdog ) > +{ > +printk("NMI watchdog is enabled. Disabling VPMU\n"); > +opt_vpmu_enabl

Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-28 Thread Boris Ostrovsky
On 01/28/2015 05:41 PM, Andrew Cooper wrote: On 28/01/2015 22:33, Boris Ostrovsky wrote: On 01/28/2015 04:49 PM, Andrew Cooper wrote: On 28/01/2015 19:56, Boris Ostrovsky wrote: NMI watchdog sets APIC_LVTPC register to generate an NMI when PMU counter overflow occurs. This may be overwritten b

Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-28 Thread Andrew Cooper
On 28/01/2015 22:33, Boris Ostrovsky wrote: > On 01/28/2015 04:49 PM, Andrew Cooper wrote: >> On 28/01/2015 19:56, Boris Ostrovsky wrote: >>> NMI watchdog sets APIC_LVTPC register to generate an NMI when PMU >>> counter >>> overflow occurs. This may be overwritten by VPMU code later, >>> effectivel

Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-28 Thread Boris Ostrovsky
On 01/28/2015 04:49 PM, Andrew Cooper wrote: On 28/01/2015 19:56, Boris Ostrovsky wrote: NMI watchdog sets APIC_LVTPC register to generate an NMI when PMU counter overflow occurs. This may be overwritten by VPMU code later, effectively turning off the watchdog. We should disable VPMU when NMI w

Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-28 Thread Andrew Cooper
On 28/01/2015 19:56, Boris Ostrovsky wrote: > NMI watchdog sets APIC_LVTPC register to generate an NMI when PMU counter > overflow occurs. This may be overwritten by VPMU code later, effectively > turning off the watchdog. > > We should disable VPMU when NMI watchdog is running. > > Signed-off-by:

[Xen-devel] [PATCH 1/2] x86/VPMU: Disable VPMU when NMI watchdog is on

2015-01-28 Thread Boris Ostrovsky
NMI watchdog sets APIC_LVTPC register to generate an NMI when PMU counter overflow occurs. This may be overwritten by VPMU code later, effectively turning off the watchdog. We should disable VPMU when NMI watchdog is running. Signed-off-by: Boris Ostrovsky --- xen/arch/x86/hvm/vpmu.c|