Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-18 Thread Jan Beulich
>>> On 18.11.15 at 17:21, wrote: > I have a suggestion to remove the "no accessing two percpu rwlock resources > simultaneously on the same PCPU" restriction: > > On accessing the second resource, we can detect that the percpu read area is > already > in use, if this is the case then we can just

Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-18 Thread Malcolm Crossley
On 18/11/15 14:15, Jan Beulich wrote: On 18.11.15 at 14:49, wrote: >> On 17/11/15 17:00, Jan Beulich wrote: >> On 03.11.15 at 18:58, wrote: Per-cpu read-write locks allow for the fast path read case to have low overhead by only setting/clearing a per-cpu variable for usin

Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-18 Thread Jan Beulich
>>> On 18.11.15 at 14:49, wrote: > On 17/11/15 17:00, Jan Beulich wrote: > On 03.11.15 at 18:58, wrote: >>> Per-cpu read-write locks allow for the fast path read case to have low >>> overhead >>> by only setting/clearing a per-cpu variable for using the read lock. >>> The per-cpu read fast p

Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-18 Thread Malcolm Crossley
On 17/11/15 17:00, Jan Beulich wrote: On 03.11.15 at 18:58, wrote: >> Per-cpu read-write locks allow for the fast path read case to have low >> overhead >> by only setting/clearing a per-cpu variable for using the read lock. >> The per-cpu read fast path also avoids locked compare swap opera

Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-17 Thread Jan Beulich
>>> On 03.11.15 at 18:58, wrote: > Per-cpu read-write locks allow for the fast path read case to have low > overhead > by only setting/clearing a per-cpu variable for using the read lock. > The per-cpu read fast path also avoids locked compare swap operations which > can > be particularly slow o

Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-05 Thread Marcos E. Matsunaga
Hi Malcolm, I tried your patches against staging yesterday and as soon as I started a guest, it panic. I have lock_profile enabled and applied your patches against: 6f04de658574833688c3f9eab310e7834d56a9c0 x86: cleanup of early cpuid handling (XEN) HVM1 save: CPU (XEN) HVM1 save: PIC (XE

Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-05 Thread Marcos E. Matsunaga
Hi Malcolm, If you can post the updated patches, that would be great. I think it would be better for me to test with your update. Thanks again. On 11/05/2015 10:20 AM, Malcolm Crossley wrote: On 05/11/15 13:48, Marcos E. Matsunaga wrote: Hi Malcolm, I tried your patches against staging yes

Re: [Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-05 Thread Malcolm Crossley
On 05/11/15 13:48, Marcos E. Matsunaga wrote: > Hi Malcolm, > > I tried your patches against staging yesterday and as soon as I started a > guest, it panic. I have > lock_profile enabled and applied your patches against: I tested with a non debug version of Xen (because I was analysing the perf

[Xen-devel] [PATCH 1/2] rwlock: add per-cpu reader-writer locks

2015-11-03 Thread Malcolm Crossley
Per-cpu read-write locks allow for the fast path read case to have low overhead by only setting/clearing a per-cpu variable for using the read lock. The per-cpu read fast path also avoids locked compare swap operations which can be particularly slow on coherent multi-socket systems, particularly if