Re: [Xen-devel] [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF

2015-11-17 Thread Wei Liu
On Tue, Nov 17, 2015 at 03:32:18PM +, Ian Campbell wrote: > On Tue, 2015-11-17 at 15:24 +, Wei Liu wrote: > > On Tue, Nov 17, 2015 at 03:21:39PM +, Ian Campbell wrote: > > > On Tue, 2015-11-17 at 15:16 +, Wei Liu wrote: > > > > On Tue, Nov 17, 2015 at 03:08:47PM +, Wei Liu wrote

Re: [Xen-devel] [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF

2015-11-17 Thread Ian Campbell
On Tue, 2015-11-17 at 15:24 +, Wei Liu wrote: > On Tue, Nov 17, 2015 at 03:21:39PM +, Ian Campbell wrote: > > On Tue, 2015-11-17 at 15:16 +, Wei Liu wrote: > > > On Tue, Nov 17, 2015 at 03:08:47PM +, Wei Liu wrote: > > > > The rune is > > > > > > > >   sed -i 's/libxl__sprintf(gc,\

Re: [Xen-devel] [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF

2015-11-17 Thread Wei Liu
On Tue, Nov 17, 2015 at 03:21:39PM +, Ian Campbell wrote: > On Tue, 2015-11-17 at 15:16 +, Wei Liu wrote: > > On Tue, Nov 17, 2015 at 03:08:47PM +, Wei Liu wrote: > > > The rune is > > > > > >   sed -i 's/libxl__sprintf(gc,\s*\(".*",.*\)/GCSPRINTF(\1/g' libxl*.c > > > > > > > Hmm...

Re: [Xen-devel] [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF

2015-11-17 Thread Ian Campbell
On Tue, 2015-11-17 at 15:16 +, Wei Liu wrote: > On Tue, Nov 17, 2015 at 03:08:47PM +, Wei Liu wrote: > > The rune is > > > >   sed -i 's/libxl__sprintf(gc,\s*\(".*",.*\)/GCSPRINTF(\1/g' libxl*.c > > > > Hmm... It looks like this rune alone doesn't cover all situations. > >  $ ack-grep '

Re: [Xen-devel] [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF

2015-11-17 Thread Wei Liu
On Tue, Nov 17, 2015 at 03:08:47PM +, Wei Liu wrote: > The rune is > > sed -i 's/libxl__sprintf(gc,\s*\(".*",.*\)/GCSPRINTF(\1/g' libxl*.c > Hmm... It looks like this rune alone doesn't cover all situations. $ ack-grep 'libxl__sprintf\(gc' | wc -l 43 Let me see if I can refine it a bi

[Xen-devel] [PATCH 1/2] libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF

2015-11-17 Thread Wei Liu
The rune is sed -i 's/libxl__sprintf(gc,\s*\(".*",.*\)/GCSPRINTF(\1/g' libxl*.c Signed-off-by: Wei Liu --- tools/libxl/libxl.c| 170 - tools/libxl/libxl_blktap2.c| 4 +- tools/libxl/libxl_bootloader.c | 10 +-- tools/libxl/libxl_creat