Re: [Xen-devel] [PATCH 1/2] hvc_xen: add earlycon support

2016-02-25 Thread Stefano Stabellini
On Wed, 24 Feb 2016, Andrew Cooper wrote: > On 24/02/16 17:18, Konrad Rzeszutek Wilk wrote: > >> I could do the same here by dropping the if (!xen_pv_domain()) check > >> above, but then if somebody specifies earlyprintk=xenboot on a non-Xen > >> environment, I expect Linux would crash. > > Nah, yo

Re: [Xen-devel] [PATCH 1/2] hvc_xen: add earlycon support

2016-02-25 Thread Stefano Stabellini
On Wed, 24 Feb 2016, Konrad Rzeszutek Wilk wrote: > > I could do the same here by dropping the if (!xen_pv_domain()) check > > above, but then if somebody specifies earlyprintk=xenboot on a non-Xen > > environment, I expect Linux would crash. > > Nah, you made it "Work" with: > commit eb5ef07151ba

Re: [Xen-devel] [PATCH 1/2] hvc_xen: add earlycon support

2016-02-24 Thread Andrew Cooper
On 24/02/16 17:18, Konrad Rzeszutek Wilk wrote: >> I could do the same here by dropping the if (!xen_pv_domain()) check >> above, but then if somebody specifies earlyprintk=xenboot on a non-Xen >> environment, I expect Linux would crash. > Nah, you made it "Work" with: > commit eb5ef07151ba3c3cb4bc

Re: [Xen-devel] [PATCH 1/2] hvc_xen: add earlycon support

2016-02-24 Thread Konrad Rzeszutek Wilk
> I could do the same here by dropping the if (!xen_pv_domain()) check > above, but then if somebody specifies earlyprintk=xenboot on a non-Xen > environment, I expect Linux would crash. Nah, you made it "Work" with: commit eb5ef07151ba3c3cb4bcef0c8f146ff1115eaa55 Author: Stefano Stabellini Date:

Re: [Xen-devel] [PATCH 1/2] hvc_xen: add earlycon support

2016-02-24 Thread Stefano Stabellini
On Wed, 24 Feb 2016, Boris Ostrovsky wrote: > On 02/24/2016 07:23 AM, Stefano Stabellini wrote: > > Introduce EARLYCON support in hvc_xen, useful for early debugging on arm > > and arm64, where xen early_printk is not available. Differently from > > xenboot_write_console on x86, we won't just retur

Re: [Xen-devel] [PATCH 1/2] hvc_xen: add earlycon support

2016-02-24 Thread Boris Ostrovsky
On 02/24/2016 07:23 AM, Stefano Stabellini wrote: Introduce EARLYCON support in hvc_xen, useful for early debugging on arm and arm64, where xen early_printk is not available. Differently from xenboot_write_console on x86, we won't just return if !xen_pv_domain(), because arm and arm64 guests are

[Xen-devel] [PATCH 1/2] hvc_xen: add earlycon support

2016-02-24 Thread Stefano Stabellini
Introduce EARLYCON support in hvc_xen, useful for early debugging on arm and arm64, where xen early_printk is not available. Differently from xenboot_write_console on x86, we won't just return if !xen_pv_domain(), because arm and arm64 guests are actually xen_hvm_domain() from linux pov, and also b