Re: [Xen-devel] [PATCH 09/27] xen/arm: traps: Don't define FAR_EL2 for ARM32

2017-08-23 Thread Julien Grall
On 08/22/2017 03:12 PM, Andre Przywara wrote: Hi, Hi Andre, On 14/08/17 15:24, Julien Grall wrote: Aliasing FAR_EL2 to HIFAR makes the code confusing because on ARMv8 FAR_EL2[31:0] is architecturally mapped to HDFAR and FAR_EL2[63:32] to FAR_EL2. ^^^ I guess you mean HIFAR here. Othe

Re: [Xen-devel] [PATCH 09/27] xen/arm: traps: Don't define FAR_EL2 for ARM32

2017-08-22 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > Aliasing FAR_EL2 to HIFAR makes the code confusing because on ARMv8 > FAR_EL2[31:0] is architecturally mapped to HDFAR and FAR_EL2[63:32] to > FAR_EL2. ^^^ I guess you mean HIFAR here. Otherwise the patch makes sense. > See D7.2.30 in ARM DDI 048

[Xen-devel] [PATCH 09/27] xen/arm: traps: Don't define FAR_EL2 for ARM32

2017-08-14 Thread Julien Grall
Aliasing FAR_EL2 to HIFAR makes the code confusing because on ARMv8 FAR_EL2[31:0] is architecturally mapped to HDFAR and FAR_EL2[63:32] to FAR_EL2. See D7.2.30 in ARM DDI 0487B.a. Open-code the alias instead. Signed-off-by: Julien Grall --- xen/arch/arm/traps.c | 8 +++- xen/include/