Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-14 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > Does that mean you're satisfied with this patch? Can I translate this > thread into an ack? Err, sorry, yes, I should have said Acked-by: Ian Jackson ___ Xen-de

Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-13 Thread Wei Liu
On Mon, Jun 13, 2016 at 05:57:26PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in > Makefile"): > > On Mon, Jun 13, 2016 at 05:07:11PM +0100, Ian Jackson wrote: > > > Mmmm. So maybe we should just drop this now. > > > > Drop what? Drop the

Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-13 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > On Mon, Jun 13, 2016 at 05:07:11PM +0100, Ian Jackson wrote: > > Mmmm. So maybe we should just drop this now. > > Drop what? Drop the uninstall target all together? Or just the rune in > this patch? I mean

Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-13 Thread Wei Liu
On Mon, Jun 13, 2016 at 05:07:11PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in > Makefile"): > > TBH I think the uninstall target has been broken for a long time. I > > merely added the rm rune for completeness. Last time I tried it didn

Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-13 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > TBH I think the uninstall target has been broken for a long time. I > merely added the rm rune for completeness. Last time I tried it didn't > remove things cleanly. For one there is no rune to remove system

Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-13 Thread Wei Liu
On Mon, Jun 13, 2016 at 04:13:26PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 08/17] tools: remove hard-coded /var/lib/xen in > Makefile"): > > Now all conversations are done, remove the hard-coded paths. > > Should we not keep these for (most of) a release cycle ? > > Otherwise someone

Re: [Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-13 Thread Ian Jackson
Wei Liu writes ("[PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > Now all conversations are done, remove the hard-coded paths. Should we not keep these for (most of) a release cycle ? Otherwise someone who tries to use the new feature in 4.8 will find it doesn't uninstall the

[Xen-devel] [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile

2016-06-13 Thread Wei Liu
Now all conversations are done, remove the hard-coded paths. Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/Makefile b/tools/Makefile index cb0817a..cc45758 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -63,7 +63,6