Re: [Xen-devel] [PATCH 06/17] x86emul: add EVEX decoding

2016-09-14 Thread Jan Beulich
>>> On 14.09.16 at 19:05, wrote: > On 08/09/16 14:12, Jan Beulich wrote: >> --- a/xen/arch/x86/x86_emulate/x86_emulate.c >> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c >> @@ -336,6 +336,27 @@ union vex { >> ptr[1] = rex | REX_PREFIX; \ >> } while (0) >> >> +union evex { >> +uint8_

Re: [Xen-devel] [PATCH 06/17] x86emul: add EVEX decoding

2016-09-14 Thread Andrew Cooper
On 08/09/16 14:12, Jan Beulich wrote: > This way we can at least size (and e.g. skip) them if needed, and we > also won't raise the wrong fault due to not having read all relevant > bytes. > > Signed-off-by: Jan Beulich > --- > TBD: I'm kind of undecided whether to right away propagate evex.R into

[Xen-devel] [PATCH 06/17] x86emul: add EVEX decoding

2016-09-08 Thread Jan Beulich
This way we can at least size (and e.g. skip) them if needed, and we also won't raise the wrong fault due to not having read all relevant bytes. Signed-off-by: Jan Beulich --- TBD: I'm kind of undecided whether to right away propagate evex.R into modrm_reg (and then also deal with the new me