Re: [Xen-devel] [PATCH 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 07:18 +0100, Julien Grall wrote: > >>> +/* Read only + read as zero */ > >> > >> This comment may confuse developer who wants to implement RO register > >> which another value than 0. > >> > >> I got confuse too. It would be nice to expand the comment for the RO case. > > > >

Re: [Xen-devel] [PATCH 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

2015-04-16 Thread Julien Grall
Hi Ian, On 16/04/2015 17:22, Ian Campbell wrote: On Fri, 2015-04-03 at 14:51 +0200, Julien Grall wrote: On 31/03/2015 12:07, Ian Campbell wrote: Signed-off-by: Ian Campbell --- xen/arch/arm/traps.c | 52 -- 1 file changed, 33 insertions(

Re: [Xen-devel] [PATCH 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

2015-04-16 Thread Ian Campbell
On Fri, 2015-04-03 at 14:51 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > Signed-off-by: Ian Campbell > > --- > > xen/arch/arm/traps.c | 52 > > -- > > 1 file changed, 33 insertions(+), 19 deletions(-) >

Re: [Xen-devel] [PATCH 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

2015-04-03 Thread Julien Grall
Hi Ian, On 31/03/2015 12:07, Ian Campbell wrote: Signed-off-by: Ian Campbell --- xen/arch/arm/traps.c | 52 -- 1 file changed, 33 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 8b1846a..ebc09f9

[Xen-devel] [PATCH 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

2015-03-31 Thread Ian Campbell
Signed-off-by: Ian Campbell --- xen/arch/arm/traps.c | 52 -- 1 file changed, 33 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 8b1846a..ebc09f9 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/t