Re: [Xen-devel] [PATCH 05/10] x86/HVM: use unambiguous register names

2016-12-21 Thread Jan Beulich
>>> On 20.12.16 at 18:39, wrote: > On 20/12/2016 10:39, Jan Beulich wrote: >> @@ -3032,16 +3032,16 @@ void hvm_task_switch( >> if ( hvm_set_cr3(tss.cr3, 1) ) >> goto out; >> >> -regs->eip= tss.eip; >> -regs->eflags = tss.eflags | 2; >> -regs->eax= tss.eax; >> -

Re: [Xen-devel] [PATCH 05/10] x86/HVM: use unambiguous register names

2016-12-20 Thread Andrew Cooper
On 20/12/2016 10:39, Jan Beulich wrote: > @@ -3032,16 +3032,16 @@ void hvm_task_switch( > if ( hvm_set_cr3(tss.cr3, 1) ) > goto out; > > -regs->eip= tss.eip; > -regs->eflags = tss.eflags | 2; > -regs->eax= tss.eax; > -regs->ecx= tss.ecx; > -regs->edx

[Xen-devel] [PATCH 05/10] x86/HVM: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@