Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-05 Thread Sergej Proskurin
Hi Julien, On 07/04/2016 08:34 PM, Julien Grall wrote: > On 04/07/16 17:51, Sergej Proskurin wrote: >> On 07/04/2016 06:15 PM, Julien Grall wrote: >>> >>> >>> On 04/07/16 12:45, Sergej Proskurin wrote: +static void p2m_teardown_hostp2m(struct domain *d) +{ +struct p2m_domain *p

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
On 07/04/2016 08:30 PM, Julien Grall wrote: > > > On 04/07/16 17:40, Sergej Proskurin wrote: >> On 07/04/2016 05:17 PM, Julien Grall wrote: >>> On 04/07/16 12:45, Sergej Proskurin wrote: > > [...] > +static struct p2m_domain *p2m_init_one(struct domain *d) +{ +struct p2m_do

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
On 07/04/2016 11:19 PM, Sergej Proskurin wrote: > > On 07/04/2016 07:44 PM, Julien Grall wrote: >> >> >> On 04/07/16 17:56, Sergej Proskurin wrote: >>> Hi Andrew, >>> >>> On 07/04/2016 06:43 PM, Andrew Cooper wrote: On 04/07/16 17:40, Sergej Proskurin wrote: > >>>{ >>> -

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Julien Grall
Hello Sergej, On 04/07/2016 22:19, Sergej Proskurin wrote: On 07/04/2016 07:44 PM, Julien Grall wrote: On 04/07/16 17:56, Sergej Proskurin wrote: On 07/04/2016 06:43 PM, Andrew Cooper wrote: On 04/07/16 17:40, Sergej Proskurin wrote: { -struct p2m_domain *p2m = &d->arch.p2m; +in

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
On 07/04/2016 08:18 PM, Julien Grall wrote: > > > On 04/07/16 17:43, Andrew Cooper wrote: >> On 04/07/16 17:40, Sergej Proskurin wrote: >>> >{ > -struct p2m_domain *p2m = &d->arch.p2m; > +int ret = 0; > + > +spin_lock_init(&p2m->lock); > +INIT_PAGE_LI

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
On 07/04/2016 07:44 PM, Julien Grall wrote: > > > On 04/07/16 17:56, Sergej Proskurin wrote: >> Hi Andrew, >> >> On 07/04/2016 06:43 PM, Andrew Cooper wrote: >>> On 04/07/16 17:40, Sergej Proskurin wrote: >>{ >> -struct p2m_domain *p2m = &d->arch.p2m; >> +int ret = 0

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Julien Grall
On 04/07/16 17:51, Sergej Proskurin wrote: On 07/04/2016 06:15 PM, Julien Grall wrote: On 04/07/16 12:45, Sergej Proskurin wrote: +static void p2m_teardown_hostp2m(struct domain *d) +{ +struct p2m_domain *p2m = p2m_get_hostp2m(d); +struct page_info *pg = NULL; +mfn_t mfn; +uns

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Julien Grall
On 04/07/16 17:40, Sergej Proskurin wrote: On 07/04/2016 05:17 PM, Julien Grall wrote: On 04/07/16 12:45, Sergej Proskurin wrote: [...] +static struct p2m_domain *p2m_init_one(struct domain *d) +{ +struct p2m_domain *p2m = xzalloc(struct p2m_domain); + +if ( !p2m ) +return

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Julien Grall
On 04/07/16 17:43, Andrew Cooper wrote: On 04/07/16 17:40, Sergej Proskurin wrote: { -struct p2m_domain *p2m = &d->arch.p2m; +int ret = 0; + +spin_lock_init(&p2m->lock); +INIT_PAGE_LIST_HEAD(&p2m->pages); + +spin_lock(&p2m->lock); + +p2m->domain = d; +p2m->acce

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Julien Grall
On 04/07/16 17:56, Sergej Proskurin wrote: Hi Andrew, On 07/04/2016 06:43 PM, Andrew Cooper wrote: On 04/07/16 17:40, Sergej Proskurin wrote: { -struct p2m_domain *p2m = &d->arch.p2m; +int ret = 0; + +spin_lock_init(&p2m->lock); +INIT_PAGE_LIST_HEAD(&p2m->pages); + +

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
Hi Andrew, On 07/04/2016 06:43 PM, Andrew Cooper wrote: > On 04/07/16 17:40, Sergej Proskurin wrote: >> { -struct p2m_domain *p2m = &d->arch.p2m; +int ret = 0; + +spin_lock_init(&p2m->lock); +INIT_PAGE_LIST_HEAD(&p2m->pages); + +spin_lo

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
Hello Julien, On 07/04/2016 06:15 PM, Julien Grall wrote: > > > On 04/07/16 12:45, Sergej Proskurin wrote: >> +static void p2m_teardown_hostp2m(struct domain *d) >> +{ >> +struct p2m_domain *p2m = p2m_get_hostp2m(d); >> +struct page_info *pg = NULL; >> +mfn_t mfn; >> +unsigned in

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Andrew Cooper
On 04/07/16 17:40, Sergej Proskurin wrote: > >>> { >>> -struct p2m_domain *p2m = &d->arch.p2m; >>> +int ret = 0; >>> + >>> +spin_lock_init(&p2m->lock); >>> +INIT_PAGE_LIST_HEAD(&p2m->pages); >>> + >>> +spin_lock(&p2m->lock); >>> + >>> +p2m->domain = d; >>> +p2m->access

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
Hello Julien, On 07/04/2016 05:17 PM, Julien Grall wrote: > Hello Sergej, > > On 04/07/16 12:45, Sergej Proskurin wrote: >> The p2m intialization now invokes intialization routines responsible for > > s/intialization/initialization/ > >> the allocation and intitialization of altp2m structures.

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Julien Grall
On 04/07/16 12:45, Sergej Proskurin wrote: +static void p2m_teardown_hostp2m(struct domain *d) +{ +struct p2m_domain *p2m = p2m_get_hostp2m(d); +struct page_info *pg = NULL; +mfn_t mfn; +unsigned int i; + +spin_lock(&p2m->lock); -if ( p2m->root ) -free_domheap_p

Re: [Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Julien Grall
Hello Sergej, On 04/07/16 12:45, Sergej Proskurin wrote: The p2m intialization now invokes intialization routines responsible for s/intialization/initialization/ the allocation and intitialization of altp2m structures. The same Ditto applies to teardown routines. The functionality has be

[Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
The p2m intialization now invokes intialization routines responsible for the allocation and intitialization of altp2m structures. The same applies to teardown routines. The functionality has been adopted from the x86 altp2m implementation. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellin

[Xen-devel] [PATCH 04/18] arm/altp2m: Add altp2m init/teardown routines.

2016-07-04 Thread Sergej Proskurin
The p2m intialization now invokes intialization routines responsible for the allocation and intitialization of altp2m structures. The same applies to teardown routines. The functionality has been adopted from the x86 altp2m implementation. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellin