Re: [Xen-devel] [PATCH 02/19] xen: arm: add missing break

2015-04-16 Thread Julien Grall
Hi Ian, On 16/04/2015 17:08, Ian Campbell wrote: On Thu, 2015-04-02 at 16:09 +0100, Julien Grall wrote: Hi Ian, On 31/03/2015 11:07, Ian Campbell wrote: Signed-off-by: Ian Campbell xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 Having injected an undefined instruction we don't want

Re: [Xen-devel] [PATCH 02/19] xen: arm: add missing break

2015-04-16 Thread Ian Campbell
On Thu, 2015-04-02 at 16:09 +0100, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 11:07, Ian Campbell wrote: > > Signed-off-by: Ian Campbell > > > > xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 > > > > Having injected an undefined instruction we don't want to also advance > > pc. So re

Re: [Xen-devel] [PATCH 02/19] xen: arm: add missing break

2015-04-02 Thread Julien Grall
Hi Ian, On 31/03/2015 11:07, Ian Campbell wrote: Signed-off-by: Ian Campbell xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 Having injected an undefined instruction we don't want to also advance pc. So return. THe ICC_{SGI0R,ASGI1R}_EL1 case was previously missing a break, so would h

[Xen-devel] [PATCH 02/19] xen: arm: add missing break

2015-03-31 Thread Ian Campbell
Signed-off-by: Ian Campbell xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 Having injected an undefined instruction we don't want to also advance pc. So return. THe ICC_{SGI0R,ASGI1R}_EL1 case was previously missing a break, so would have fallen through to the default case and injected