Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Julien Grall
Hi Wei, On 10/04/17 10:47, Wei Liu wrote: Cc Julien These are small bug fixes that can be safely committed, IMHO. Release-acked-by: Julien Grall Cheers, On Fri, Apr 07, 2017 at 02:27:17PM +0100, Jonathan Davies wrote: In order to make oxenstored restartable, we need to save internal sta

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Wei Liu
Cc Julien These are small bug fixes that can be safely committed, IMHO. On Fri, Apr 07, 2017 at 02:27:17PM +0100, Jonathan Davies wrote: > In order to make oxenstored restartable, we need to save internal state > to a file on exit and restore from this file on startup. > > Much of the infrastru

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Christian Lindig
> On 10. Apr 2017, at 09:33, Wei Liu wrote: > > On Mon, Apr 10, 2017 at 09:10:15AM +0100, Christian Lindig wrote: >> >>> On 7. Apr 2017, at 14:27, Jonathan Davies >>> wrote: >>> >>> tools/ocaml/xenstored/domain.ml| 4 ++-- >>> tools/ocaml/xenstored/store.ml | 8 +++- >>> tools/oc

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Wei Liu
On Mon, Apr 10, 2017 at 09:10:15AM +0100, Christian Lindig wrote: > > > On 7. Apr 2017, at 14:27, Jonathan Davies > > wrote: > > > > tools/ocaml/xenstored/domain.ml| 4 ++-- > > tools/ocaml/xenstored/store.ml | 8 +++- > > tools/ocaml/xenstored/xenstored.ml | 10 ++ > > The

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Christian Lindig
> On 7. Apr 2017, at 14:27, Jonathan Davies wrote: > > tools/ocaml/xenstored/domain.ml| 4 ++-- > tools/ocaml/xenstored/store.ml | 8 +++- > tools/ocaml/xenstored/xenstored.ml | 10 ++ The OCaml code is looking good and I’d be happy to take it as it is. I noticed that the (

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Juergen Gross
On 07/04/17 16:31, Jonathan Davies wrote: > On 07/04/17 15:21, Juergen Gross wrote: >> Is the data format of the saved state documented somewhere? I'd >> appreciate any pointer or (in case there is no such doc) a followup >> patch to add the documentation. >> >> This would help later in case C-xens

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Jonathan Davies
On 07/04/17 15:21, Juergen Gross wrote: Is the data format of the saved state documented somewhere? I'd appreciate any pointer or (in case there is no such doc) a followup patch to add the documentation. This would help later in case C-xenstored learns restartability, too, and someone would like

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Jonathan Davies
On 07/04/17 15:15, Andrew Cooper wrote: On 07/04/17 14:27, Jonathan Davies wrote: With these patches, the state saved on exit contains information about inter-domain connections and active watches, and the contents of the store. Some internal state is not currently preserved over a restart: 1.

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Juergen Gross
On 07/04/17 16:09, Wei Liu wrote: > On Fri, Apr 07, 2017 at 02:27:17PM +0100, Jonathan Davies wrote: >> In order to make oxenstored restartable, we need to save internal state >> to a file on exit and restore from this file on startup. >> >> Much of the infrastructure for making oxenstored restart

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Andrew Cooper
On 07/04/17 14:27, Jonathan Davies wrote: > With these patches, the state saved on exit contains information about > inter-domain connections and active watches, and the contents of the > store. Some internal state is not currently preserved over a restart: > 1. quota usage info > 2. partially

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Wei Liu
On Fri, Apr 07, 2017 at 02:27:17PM +0100, Jonathan Davies wrote: > In order to make oxenstored restartable, we need to save internal state > to a file on exit and restore from this file on startup. > > Much of the infrastructure for making oxenstored restartable already > existed, but a handful

[Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Jonathan Davies
In order to make oxenstored restartable, we need to save internal state to a file on exit and restore from this file on startup. Much of the infrastructure for making oxenstored restartable already existed, but a handful of bugs prevented it from working. After these patches I can do the follow