Re: [Xen-devel] [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF

2015-11-17 Thread Wei Liu
On Tue, Nov 17, 2015 at 03:34:30PM +, David Vrabel wrote: > On 17/11/15 15:08, Wei Liu wrote: > > There are mixed usage of libxl__sprintf(gc) and GCSPRINTF. Convert all > > libxl__sprintf to GCSPRINTF. > > This looks like pointless churn /and/ GCSPRINTF is /less/ readable than > libxl__sprintf

Re: [Xen-devel] [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF

2015-11-17 Thread David Vrabel
On 17/11/15 15:08, Wei Liu wrote: > There are mixed usage of libxl__sprintf(gc) and GCSPRINTF. Convert all > libxl__sprintf to GCSPRINTF. This looks like pointless churn /and/ GCSPRINTF is /less/ readable than libxl__sprintf(gc,...) because the reader now has to also look up what GCSPRINTF does.

[Xen-devel] [PATCH 0/2] Convert libxl__sprintf(gc) to GCSPRINTF

2015-11-17 Thread Wei Liu
There are mixed usage of libxl__sprintf(gc) and GCSPRINTF. Convert all libxl__sprintf to GCSPRINTF. Wei Liu (2): libxl: replace libxl__sprintf(gc, ...) with GCSPRINTF libxl: fix line wrapping issues introduced by sed tools/libxl/libxl.c| 181 --