George Dunlap writes ("Re: [Xen-devel] [PATCH] xl: remove stale comment"):
> On Thu, Feb 2, 2017 at 4:07 PM, Ian Jackson wrote:
> > Ie, why does xl have this code at all ? Why is its handling of
> > LIBXL_EVENT_TYPE_DISK_EJECT not to simply ignore it ? Why does it
>
On Thu, Feb 2, 2017 at 4:07 PM, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] xl: remove stale comment"):
>> On Thu, Feb 02, 2017 at 03:56:03PM +, Ian Jackson wrote:
>> > Wei Liu writes ("[PATCH] xl: remove stale comment"):
>> > > case LIBXL_EVENT_TYPE_DISK_EJECT:
>> > > -
Wei Liu writes ("Re: [PATCH] xl: remove stale comment"):
> On Thu, Feb 02, 2017 at 03:56:03PM +, Ian Jackson wrote:
> > Wei Liu writes ("[PATCH] xl: remove stale comment"):
> > > case LIBXL_EVENT_TYPE_DISK_EJECT:
> > > -/* XXX what is this for? */
> > > libxl_c
On Thu, Feb 02, 2017 at 03:56:03PM +, Ian Jackson wrote:
> Wei Liu writes ("[PATCH] xl: remove stale comment"):
> > Obvious the DISK_EJECT event is for ejecting removable media.
>
> The question is...
>
> > case LIBXL_EVENT_TYPE_DISK_EJECT:
> > -/* XXX what is this for? *
Wei Liu writes ("[PATCH] xl: remove stale comment"):
> Obvious the DISK_EJECT event is for ejecting removable media.
The question is...
> case LIBXL_EVENT_TYPE_DISK_EJECT:
> -/* XXX what is this for? */
> libxl_cdrom_insert(ctx, domid, &event->u.disk_eject.disk,
Obvious the DISK_EJECT event is for ejecting removable media.
Signed-off-by: Wei Liu
---
Cc: Ian Jackson
Ian, feel free to tell me that I'm wrong...
---
tools/libxl/xl_cmdimpl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 196b8a6
