Re: [Xen-devel] [PATCH] xenconsoled: Remove unexpected daemonize behavior

2015-11-04 Thread Ian Campbell
On Tue, 2015-11-03 at 17:20 +, Wei Liu wrote: > Acked-by: Wei Liu Applied w/ this + Ian J's ack. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xenconsoled: Remove unexpected daemonize behavior

2015-11-03 Thread Wei Liu
On Mon, Nov 02, 2015 at 04:45:37PM +, Ross Lagerwall wrote: > On 11/02/2015 04:37 PM, Wei Liu wrote: > >On Mon, Nov 02, 2015 at 11:17:38AM +, Ross Lagerwall wrote: > >>Previously, xenconsoled's daemonize function would do nothing if its > >>parent process is init (as it is under systemd but

Re: [Xen-devel] [PATCH] xenconsoled: Remove unexpected daemonize behavior

2015-11-02 Thread Ian Jackson
Ross Lagerwall writes ("[PATCH] xenconsoled: Remove unexpected daemonize behavior"): > Previously, xenconsoled's daemonize function would do nothing if its > parent process is init (as it is under systemd but not sysv init). > > This is confusing. It's quite bogglesome, indeed. > Instead, alway

Re: [Xen-devel] [PATCH] xenconsoled: Remove unexpected daemonize behavior

2015-11-02 Thread Ross Lagerwall
On 11/02/2015 04:37 PM, Wei Liu wrote: On Mon, Nov 02, 2015 at 11:17:38AM +, Ross Lagerwall wrote: Previously, xenconsoled's daemonize function would do nothing if its parent process is init (as it is under systemd but not sysv init). This is confusing. Instead, always daemonize when asked t

Re: [Xen-devel] [PATCH] xenconsoled: Remove unexpected daemonize behavior

2015-11-02 Thread Wei Liu
On Mon, Nov 02, 2015 at 11:17:38AM +, Ross Lagerwall wrote: > Previously, xenconsoled's daemonize function would do nothing if its > parent process is init (as it is under systemd but not sysv init). > This is confusing. Instead, always daemonize when asked to, but use the > "interactive" switc

[Xen-devel] [PATCH] xenconsoled: Remove unexpected daemonize behavior

2015-11-02 Thread Ross Lagerwall
Previously, xenconsoled's daemonize function would do nothing if its parent process is init (as it is under systemd but not sysv init). This is confusing. Instead, always daemonize when asked to, but use the "interactive" switch when running from the systemd service. Because a pidfile is only writ