Re: [Xen-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-15 Thread Paolo Bonzini
On 15/04/2015 16:14, Li, Liang Z wrote: > Yes, it's the right place. Put aside the bug fix, I think the > memory_region_ref/unref pair > should be move to xen_pt_region_update after the conditional as you point > out. > Do you think so? It would make sense, but I was just guessing... I'm s

Re: [Xen-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-15 Thread Li, Liang Z
> On 13/04/2015 16:12, Liang Li wrote: > > 2. Do the attach and detach operation with a time interval. eg. 10s. > > > > The error message will not disappear if retry, in this case, it's > > a bug. > > > > In the 'xen_pt_region_add' and 'xen_pt_region_del', we should only > > care about

Re: [Xen-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 16:12, Liang Li wrote: > 2. Do the attach and detach operation with a time interval. eg. 10s. > > The error message will not disappear if retry, in this case, it's > a bug. > > In the 'xen_pt_region_add' and 'xen_pt_region_del', we should only care > about the 'xen-pc

[Xen-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-13 Thread Liang Li
Use the option like 'pci=[ '07:10,1', '0b:10.1', '81:10.1']' in HVM guest configuration file to assign more than one VF PCI devices to a guest, after the guest boot up, detach the VFs in sequence by 'xl pci-detach $DOM_ID $VF_BDF', and then attach the VFs by 'xl pci-attach $DOM_ID $VF_BDF' in seque