Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-14 Thread Konrad Rzeszutek Wilk
On Mon, Dec 14, 2015 at 04:08:13PM +, David Vrabel wrote: > On 02/12/15 14:56, Doug Goldstein wrote: > > On 12/2/15 4:35 AM, David Vrabel wrote: > >> On 26/11/15 20:32, Doug Goldstein wrote: > >>> When allocating a pciback device fails, avoid the possibility of a > >>> use after free. > >> > >>

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-14 Thread David Vrabel
On 02/12/15 14:56, Doug Goldstein wrote: > On 12/2/15 4:35 AM, David Vrabel wrote: >> On 26/11/15 20:32, Doug Goldstein wrote: >>> When allocating a pciback device fails, avoid the possibility of a >>> use after free. >> >> We should not require clearing drvdata for correctness. We should >> ensur

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-02 Thread Doug Goldstein
On 12/2/15 4:35 AM, David Vrabel wrote: > On 26/11/15 20:32, Doug Goldstein wrote: >> When allocating a pciback device fails, avoid the possibility of a >> use after free. > > We should not require clearing drvdata for correctness. We should > ensure we retain drvdata for as long as it is needed.

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-02 Thread David Vrabel
On 26/11/15 20:32, Doug Goldstein wrote: > When allocating a pciback device fails, avoid the possibility of a > use after free. We should not require clearing drvdata for correctness. We should ensure we retain drvdata for as long as it is needed. I note that pcistub_device_release() has:

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Konrad Rzeszutek Wilk
On Tue, Dec 01, 2015 at 02:54:33PM -0600, Doug Goldstein wrote: > On 12/1/15 1:35 PM, Konrad Rzeszutek Wilk wrote: > > On Tue, Dec 01, 2015 at 11:47:17AM -0500, Konrad Rzeszutek Wilk wrote: > >> On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: > >>> When allocating a pciback device f

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Doug Goldstein
On 12/1/15 1:35 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 01, 2015 at 11:47:17AM -0500, Konrad Rzeszutek Wilk wrote: >> On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: >>> When allocating a pciback device fails, avoid the possibility of a >>> use after free. >> >> Reviewed-by:

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Konrad Rzeszutek Wilk
On Tue, Dec 01, 2015 at 11:47:17AM -0500, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: > > When allocating a pciback device fails, avoid the possibility of a > > use after free. > > Reviewed-by: Konrad Rzeszutek Wilk > > Ugh, and it looks like xe

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Doug Goldstein
On 12/1/15 10:47 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: >> When allocating a pciback device fails, avoid the possibility of a >> use after free. > > Reviewed-by: Konrad Rzeszutek Wilk > > Ugh, and it looks like xen-blkfront has the same

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Konrad Rzeszutek Wilk
On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: > When allocating a pciback device fails, avoid the possibility of a > use after free. Reviewed-by: Konrad Rzeszutek Wilk Ugh, and it looks like xen-blkfront has the same issue. > > Reported-by: Jonathan Creekmore > Signed-off-by

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-11-30 Thread Boris Ostrovsky
On 11/26/2015 03:32 PM, Doug Goldstein wrote: When allocating a pciback device fails, avoid the possibility of a use after free. Reported-by: Jonathan Creekmore Signed-off-by: Doug Goldstein --- drivers/xen/xen-pciback/xenbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Revi

[Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-11-26 Thread Doug Goldstein
When allocating a pciback device fails, avoid the possibility of a use after free. Reported-by: Jonathan Creekmore Signed-off-by: Doug Goldstein --- drivers/xen/xen-pciback/xenbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers