Re: [Xen-devel] [PATCH] xen-netback: do not report success if xenvif_alloc() fails

2014-11-24 Thread Alexey Khoroshilov
On 24.11.2014 13:00, Wei Liu wrote: > On Sat, Nov 22, 2014 at 01:56:28AM +0300, Alexey Khoroshilov wrote: >> If xenvif_alloc() failes, netback_probe() reports success as well as >> "online" uevent is emitted. It does not make any sense, but it just > Sorry, I don't follow. KOBJ_ONLINE event is not

Re: [Xen-devel] [PATCH] xen-netback: do not report success if xenvif_alloc() fails

2014-11-24 Thread Wei Liu
On Sat, Nov 22, 2014 at 01:56:28AM +0300, Alexey Khoroshilov wrote: > If xenvif_alloc() failes, netback_probe() reports success as well as > "online" uevent is emitted. It does not make any sense, but it just Sorry, I don't follow. KOBJ_ONLINE event is not emitted in the event of xenvif_alloc fail

[Xen-devel] [PATCH] xen-netback: do not report success if xenvif_alloc() fails

2014-11-24 Thread Alexey Khoroshilov
If xenvif_alloc() failes, netback_probe() reports success as well as "online" uevent is emitted. It does not make any sense, but it just misleads users. The patch implements propagation of error code if xenvif creation fails. Found by Linux Driver Verification project (linuxtesting.org). Signed-