Re: [Xen-devel] [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:26:16 -0400 > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun > --- > drivers/net/xen-netback/xenbus.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers

Re: [Xen-devel] [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread Insu Yun
Sorry for wrong format, I forgot to change my configuration. On Thu, Oct 15, 2015 at 1:13 PM, Wei Liu wrote: > On Thu, Oct 15, 2015 at 12:26:16PM -0400, Insu Yun wrote: > > Since vzalloc can be failed in memory pressure, > > return value should be checked and return ENOMEM. > > This function doe

Re: [Xen-devel] [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread Wei Liu
On Thu, Oct 15, 2015 at 12:26:16PM -0400, Insu Yun wrote: > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. This function doesn't return ENOMEM, instead it writes to xenstore to indicate error. The commit log needs to be updated. > > Signed-off

Re: [Xen-devel] [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread Ian Campbell
On Thu, 2015-10-15 at 12:26 -0400, Insu Yun wrote: > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun > --- > drivers/net/xen-netback/xenbus.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net

[Xen-devel] [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread Insu Yun
Since vzalloc can be failed in memory pressure, return value should be checked and return ENOMEM. Signed-off-by: Insu Yun --- drivers/net/xen-netback/xenbus.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 929a6e