Re: [Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

2016-10-27 Thread Meng Xu
Sorry, I accidentally sent out the previous email... On Thu, Oct 27, 2016 at 6:03 AM, Wei Liu wrote: > On Thu, Oct 27, 2016 at 11:14:36AM +0200, Dario Faggioli wrote: >> On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote: >> > We keep last_start updated whenever cur_budget is updated. >> > This avo

Re: [Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

2016-10-27 Thread Wei Liu
On Thu, Oct 27, 2016 at 09:42:56AM -0400, Meng Xu wrote: > Sorry, I accidentally sent out the previous email... > > On Thu, Oct 27, 2016 at 6:03 AM, Wei Liu wrote: > > On Thu, Oct 27, 2016 at 11:14:36AM +0200, Dario Faggioli wrote: > >> On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote: > >> > We

Re: [Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

2016-10-27 Thread Meng Xu
Hi Wei and Dario, On Thu, Oct 27, 2016 at 6:03 AM, Wei Liu wrote: > On Thu, Oct 27, 2016 at 11:14:36AM +0200, Dario Faggioli wrote: >> On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote: >> > We keep last_start updated whenever cur_budget is updated. >> > This avoids subtle bugs in case burn_budge

Re: [Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

2016-10-27 Thread Wei Liu
On Thu, Oct 27, 2016 at 11:14:36AM +0200, Dario Faggioli wrote: > On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote: > > We keep last_start updated whenever cur_budget is updated. > > This avoids subtle bugs in case burn_budget() will be called > > in other places in the future. > > > I'd change th

Re: [Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

2016-10-27 Thread Dario Faggioli
On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote: > We keep last_start updated whenever cur_budget is updated. > This avoids subtle bugs in case burn_budget() will be called > in other places in the future. > I'd change this into something like: "Make budget accounting code more consistent by mak

[Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

2016-10-26 Thread Meng Xu
We keep last_start updated whenever cur_budget is updated. This avoids subtle bugs in case burn_budget() will be called in other places in the future. Signed-off-by: Meng Xu --- Cc: Dario Faggioli Cc: George Dunlap Cc: Wei Liu Cc: Linh Thi Xuan Phan Cc: Haoran Li Cc: Meng Xu Cc: Dagaen Golo