Re: [Xen-devel] [PATCH] xen: x86: remove duplicated IA32_FEATURE_CONTROL MSR macro

2016-06-27 Thread Tian, Kevin
> From: Huang, Kai [mailto:kai.hu...@linux.intel.com] > Sent: Saturday, June 25, 2016 6:16 AM > > > >>> #define IA32_FEATURE_CONTROL_MSR_LOCK 0x0001 > >>> #define IA32_FEATURE_CONTROL_MSR_ENABLE_VMXON_INSIDE_SMX 0x0002 > >>> #define IA32_FEATURE_CONTROL_MSR_ENABLE_VMXON_OUTS

Re: [Xen-devel] [PATCH] xen: x86: remove duplicated IA32_FEATURE_CONTROL MSR macro

2016-06-24 Thread Huang, Kai
Hi Kevin, Jan, Thanks for comments. On 6/24/2016 11:31 PM, Jan Beulich wrote: On 24.06.16 at 12:56, wrote: From: kaih.li...@gmail.com [mailto:kaih.li...@gmail.com] Sent: Friday, June 24, 2016 6:45 PM --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -133,12 +133,

Re: [Xen-devel] [PATCH] xen: x86: remove duplicated IA32_FEATURE_CONTROL MSR macro

2016-06-24 Thread Jan Beulich
>>> On 24.06.16 at 12:56, wrote: >> From: kaih.li...@gmail.com [mailto:kaih.li...@gmail.com] >> Sent: Friday, June 24, 2016 6:45 PM >> --- a/xen/include/asm-x86/msr-index.h >> +++ b/xen/include/asm-x86/msr-index.h >> @@ -133,12 +133,13 @@ >> #define MSR_IA32_VMX_TRUE_EXIT_CTLS 0x48f

Re: [Xen-devel] [PATCH] xen: x86: remove duplicated IA32_FEATURE_CONTROL MSR macro

2016-06-24 Thread Tian, Kevin
> From: kaih.li...@gmail.com [mailto:kaih.li...@gmail.com] > Sent: Friday, June 24, 2016 6:45 PM > > From: Kai Huang > > Below commit introduced a new macro MSR_IA32_FEATURE_CONTROL for > IA32_FEATURE_CONTROL MSR but it didn't remove old IA32_FEATURE_CONTROL_MSR > macro. The new one has better n

[Xen-devel] [PATCH] xen: x86: remove duplicated IA32_FEATURE_CONTROL MSR macro

2016-06-24 Thread kaih . linux
From: Kai Huang Below commit introduced a new macro MSR_IA32_FEATURE_CONTROL for IA32_FEATURE_CONTROL MSR but it didn't remove old IA32_FEATURE_CONTROL_MSR macro. The new one has better naming convention, so remove the old as duplication and replace the relevant code with new one. mwait-idle