Re: [Xen-devel] [PATCH] xen: sched: avoid races on time values read from NOW()

2016-05-24 Thread Dario Faggioli
On Tue, 2016-05-24 at 04:08 -0600, Jan Beulich wrote: > While backporting this for 4.6 (which required substantial > adjustment to the sched_rt.c part) > Yep, I figure it did. :-( It sounds like you've pretty much done with it, but if not, and if you want me or Meng to provide the backport, just

Re: [Xen-devel] [PATCH] xen: sched: avoid races on time values read from NOW()

2016-05-24 Thread Jan Beulich
>>> On 19.05.16 at 10:11, wrote: > --- a/xen/common/sched_rt.c > +++ b/xen/common/sched_rt.c > @@ -1198,7 +1198,7 @@ static void > rt_vcpu_wake(const struct scheduler *ops, struct vcpu *vc) > { > struct rt_vcpu * const svc = rt_vcpu(vc); > -s_time_t now = NOW(); > +s_time_t now; >

Re: [Xen-devel] [PATCH] xen: sched: avoid races on time values read from NOW()

2016-05-19 Thread Meng Xu
On Thu, May 19, 2016 at 4:11 AM, Dario Faggioli wrote: > or (even in cases where there is no race, e.g., outside > of Credit2) avoid using a time sample which may be rather > old, and hence stale. > > In fact, we should only sample NOW() from _inside_ > the critical region within which the value w

Re: [Xen-devel] [PATCH] xen: sched: avoid races on time values read from NOW()

2016-05-19 Thread Wei Liu
On Thu, May 19, 2016 at 10:11:35AM +0200, Dario Faggioli wrote: > or (even in cases where there is no race, e.g., outside > of Credit2) avoid using a time sample which may be rather > old, and hence stale. > > In fact, we should only sample NOW() from _inside_ > the critical region within which th

Re: [Xen-devel] [PATCH] xen: sched: avoid races on time values read from NOW()

2016-05-19 Thread George Dunlap
On 19/05/16 09:11, Dario Faggioli wrote: > or (even in cases where there is no race, e.g., outside > of Credit2) avoid using a time sample which may be rather > old, and hence stale. > > In fact, we should only sample NOW() from _inside_ > the critical region within which the value we read is > us

[Xen-devel] [PATCH] xen: sched: avoid races on time values read from NOW()

2016-05-19 Thread Dario Faggioli
or (even in cases where there is no race, e.g., outside of Credit2) avoid using a time sample which may be rather old, and hence stale. In fact, we should only sample NOW() from _inside_ the critical region within which the value we read is used. If we don't, in case we have to spin for a while be