Re: [Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

2017-09-29 Thread Andrew Cooper
On 29/09/17 10:28, Juergen Gross wrote: > On 29/09/17 11:22, Andrew Cooper wrote: >> On 29/09/17 10:02, Juergen Gross wrote: >>> On 29/09/17 10:55, Roger Pau Monné wrote: On Fri, Sep 29, 2017 at 05:39:22AM +, Juergen Gross wrote: > In case gnttab_grow_table() is being called without gr

Re: [Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

2017-09-29 Thread Juergen Gross
On 29/09/17 11:22, Andrew Cooper wrote: > On 29/09/17 10:02, Juergen Gross wrote: >> On 29/09/17 10:55, Roger Pau Monné wrote: >>> On Fri, Sep 29, 2017 at 05:39:22AM +, Juergen Gross wrote: In case gnttab_grow_table() is being called without grant_table_init() having been called for t

Re: [Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

2017-09-29 Thread Andrew Cooper
On 29/09/17 10:02, Juergen Gross wrote: > On 29/09/17 10:55, Roger Pau Monné wrote: >> On Fri, Sep 29, 2017 at 05:39:22AM +, Juergen Gross wrote: >>> In case gnttab_grow_table() is being called without grant_table_init() >>> having been called for the domain, e.g. in case of a toolstack error,

Re: [Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

2017-09-29 Thread Roger Pau Monné
On Fri, Sep 29, 2017 at 09:02:12AM +, Juergen Gross wrote: > On 29/09/17 10:55, Roger Pau Monné wrote: > > On Fri, Sep 29, 2017 at 05:39:22AM +, Juergen Gross wrote: > >> +return 0; > > > > This return 0 has confused me, I was going to ask to return ENODEV, > > but then I saw this

Re: [Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

2017-09-29 Thread Juergen Gross
On 29/09/17 10:55, Roger Pau Monné wrote: > On Fri, Sep 29, 2017 at 05:39:22AM +, Juergen Gross wrote: >> In case gnttab_grow_table() is being called without grant_table_init() >> having been called for the domain, e.g. in case of a toolstack error, >> fail the function instead of crashing the

Re: [Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

2017-09-29 Thread Roger Pau Monné
On Fri, Sep 29, 2017 at 05:39:22AM +, Juergen Gross wrote: > In case gnttab_grow_table() is being called without grant_table_init() > having been called for the domain, e.g. in case of a toolstack error, > fail the function instead of crashing the system. > > Signed-off-by: Juergen Gross > --

[Xen-devel] [PATCH] xen: fail gnttab_grow_table() in case of missing allocations

2017-09-28 Thread Juergen Gross
In case gnttab_grow_table() is being called without grant_table_init() having been called for the domain, e.g. in case of a toolstack error, fail the function instead of crashing the system. Signed-off-by: Juergen Gross --- xen/common/grant_table.c | 6 +- 1 file changed, 5 insertions(+), 1