Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-15 Thread Julien Grall
On 14/03/16 17:18, Shanker Donthineni wrote: Hi Julien, Hi Shanker, On 03/12/2016 10:03 AM, Julien Grall wrote: Hi, On 11/03/2016 20:24, Andrew Cooper wrote: On 11/03/16 13:13, Jan Beulich wrote: On 11.03.16 at 13:56, wrote: On 11/03/16 11:29, Jan Beulich wrote: On 10.03.16 at 23:00,

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-14 Thread Shanker Donthineni
Hi Julien, On 03/12/2016 10:03 AM, Julien Grall wrote: > Hi, > > On 11/03/2016 20:24, Andrew Cooper wrote: >> On 11/03/16 13:13, Jan Beulich wrote: >> On 11.03.16 at 13:56, wrote: On 11/03/16 11:29, Jan Beulich wrote: On 10.03.16 at 23:00, wrote: >> @@ -771,6 +772,7 @@ voi

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-14 Thread Julien Grall
Hi Shanker, On 11/03/2016 05:00, Shanker Donthineni wrote: From: Vikram Sethi arch/arm/mm.c has 2 uses of alloc_boot_pages which are used for pagetables, but the allocated pages are not zeroed. This can cause crashes on CPUs with aggressive prefetching when they find 'valid' entries in the pag

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-14 Thread Julien Grall
Hi, On 11/03/2016 18:29, Jan Beulich wrote: On 10.03.16 at 23:00, wrote: --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -730,6 +730,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, else { unsigned long first_mfn = alloc_boot_pages(1, 1); +

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-14 Thread Julien Grall
Hi, On 11/03/2016 20:24, Andrew Cooper wrote: On 11/03/16 13:13, Jan Beulich wrote: On 11.03.16 at 13:56, wrote: On 11/03/16 11:29, Jan Beulich wrote: On 10.03.16 at 23:00, wrote: @@ -771,6 +772,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) nr_second = frametabl

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-11 Thread Andrew Cooper
On 11/03/16 13:13, Jan Beulich wrote: On 11.03.16 at 13:56, wrote: >> On 11/03/16 11:29, Jan Beulich wrote: >> On 10.03.16 at 23:00, wrote: @@ -771,6 +772,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) nr_second = frametable_size >> SECOND_SHIFT;

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-11 Thread Jan Beulich
>>> On 11.03.16 at 13:56, wrote: > On 11/03/16 11:29, Jan Beulich wrote: > On 10.03.16 at 23:00, wrote: >>> @@ -771,6 +772,7 @@ void __init setup_frametable_mappings(paddr_t ps, >>> paddr_t pe) >>> nr_second = frametable_size >> SECOND_SHIFT; >>> second_base = alloc_boot_pages(nr_s

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-11 Thread Andrew Cooper
On 11/03/16 11:29, Jan Beulich wrote: On 10.03.16 at 23:00, wrote: > First of all - please correctly Cc maintainers (there were two recent > changes for ARM). > >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -730,6 +730,7 @@ void __init setup_xenheap_mappings(unsigned long >> ba

Re: [Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-11 Thread Jan Beulich
>>> On 10.03.16 at 23:00, wrote: First of all - please correctly Cc maintainers (there were two recent changes for ARM). > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -730,6 +730,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, > else > { >

[Xen-devel] [PATCH] xen: arm: zero EL2 pagetable pages before use

2016-03-10 Thread Shanker Donthineni
From: Vikram Sethi arch/arm/mm.c has 2 uses of alloc_boot_pages which are used for pagetables, but the allocated pages are not zeroed. This can cause crashes on CPUs with aggressive prefetching when they find 'valid' entries in the page tables but which are really uninitialized. Memset the alloca