Re: [Xen-devel] [PATCH] xen: arm: Document xenheap_megabytes limitation

2015-07-24 Thread Ian Campbell
On Thu, 2015-07-23 at 17:49 +0100, Julien Grall wrote: > Hi Chris, > > Thank you for patch. > > On 23/07/15 17:31, Chris (Christopher) Brand wrote: > > In setup_mm(), the value passed as xenheap_megabytes gets > > converted to pages and passed to setup_xenheap_mappings(), > > which in turn passes

Re: [Xen-devel] [PATCH] xen: arm: Document xenheap_megabytes limitation

2015-07-23 Thread Julien Grall
Hi Chris, Thank you for patch. On 23/07/15 17:31, Chris (Christopher) Brand wrote: > In setup_mm(), the value passed as xenheap_megabytes gets > converted to pages and passed to setup_xenheap_mappings(), > which in turn passes it to create_32mb_mappings(), which > contains an ASSERT that the valu

[Xen-devel] [PATCH] xen: arm: Document xenheap_megabytes limitation

2015-07-23 Thread Chris (Christopher) Brand
In setup_mm(), the value passed as xenheap_megabytes gets converted to pages and passed to setup_xenheap_mappings(), which in turn passes it to create_32mb_mappings(), which contains an ASSERT that the value passed is a multiple of 32MB. So specifying any value that is not an integer multiple of 32