Re: [Xen-devel] [PATCH] xen: Avoid left shifting into a sign bit

2016-02-17 Thread Wu, Feng
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, February 18, 2016 3:52 AM > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Tim Deegan ; Ian Campbell > ; Tian, Kevin ; Wu, Feng > > Subject: [PATCH] xen: Avoid left shifting into a sign

[Xen-devel] [PATCH] xen: Avoid left shifting into a sign bit

2016-02-17 Thread Andrew Cooper
Clang 3.8 notices, and objects because it is undefined behaviour. "error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]" Use unsigned constants rather than signed ones. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Tim Deegan CC: Ian Campbell CC: Kevi