Re: [Xen-devel] [PATCH] xen/x86: Identify legitimate fallthrough cases

2016-07-18 Thread George Dunlap
On 18/07/16 10:30, Andrew Cooper wrote: > The case in arch_set_info_guest() is a legitimate fallthrough. Mark it as > such. > > The cases in vlapic_accept_irq() are a terminal error path, but Coverity fails > to spot this. Reorder the comment to the end. > > No functional change, but fixes two

[Xen-devel] [PATCH] xen/x86: Identify legitimate fallthrough cases

2016-07-18 Thread Andrew Cooper
The case in arch_set_info_guest() is a legitimate fallthrough. Mark it as such. The cases in vlapic_accept_irq() are a terminal error path, but Coverity fails to spot this. Reorder the comment to the end. No functional change, but fixes two MISSING_BREAK Coverity defects. Signed-off-by: Andrew