Re: [Xen-devel] [PATCH] xen/pciif: Clarify what values go in op->err and op->result.

2015-04-15 Thread Konrad Rzeszutek Wilk
On Wed, Apr 15, 2015 at 05:05:16PM +0100, Ian Campbell wrote: > On Tue, 2015-03-31 at 12:29 -0400, Konrad Rzeszutek Wilk wrote: > > On Tue, Mar 31, 2015 at 05:05:23PM +0100, Ian Campbell wrote: > > > On Tue, 2015-03-31 at 10:58 -0400, Konrad Rzeszutek Wilk wrote: > > > > The earlier comment says th

Re: [Xen-devel] [PATCH] xen/pciif: Clarify what values go in op->err and op->result.

2015-04-15 Thread Ian Campbell
On Tue, 2015-03-31 at 12:29 -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 31, 2015 at 05:05:23PM +0100, Ian Campbell wrote: > > On Tue, 2015-03-31 at 10:58 -0400, Konrad Rzeszutek Wilk wrote: > > > The earlier comment says that errno values go in op->err. > > > However all implementations (NetB

Re: [Xen-devel] [PATCH] xen/pciif: Clarify what values go in op->err and op->result.

2015-03-31 Thread Konrad Rzeszutek Wilk
On Tue, Mar 31, 2015 at 05:05:23PM +0100, Ian Campbell wrote: > On Tue, 2015-03-31 at 10:58 -0400, Konrad Rzeszutek Wilk wrote: > > The earlier comment says that errno values go in op->err. > > However all implementations (NetBSD, Linux) of the most > > common operations use XEN_PCI_ERR_* instead o

Re: [Xen-devel] [PATCH] xen/pciif: Clarify what values go in op->err and op->result.

2015-03-31 Thread Ian Campbell
On Tue, 2015-03-31 at 10:58 -0400, Konrad Rzeszutek Wilk wrote: > The earlier comment says that errno values go in op->err. > However all implementations (NetBSD, Linux) of the most > common operations use XEN_PCI_ERR_* instead of -EXX values. > > The exception is the xen-pciback in Linux code whe

Re: [Xen-devel] [PATCH] xen/pciif: Clarify what values go in op->err and op->result.

2015-03-31 Thread Konrad Rzeszutek Wilk
On Tue, Mar 31, 2015 at 10:58:32AM -0400, Konrad Rzeszutek Wilk wrote: > The earlier comment says that errno values go in op->err. > However all implementations (NetBSD, Linux) of the most > common operations use XEN_PCI_ERR_* instead of -EXX values. > > The exception is the xen-pciback in Linux c

[Xen-devel] [PATCH] xen/pciif: Clarify what values go in op->err and op->result.

2015-03-31 Thread Konrad Rzeszutek Wilk
The earlier comment says that errno values go in op->err. However all implementations (NetBSD, Linux) of the most common operations use XEN_PCI_ERR_* instead of -EXX values. The exception is the xen-pciback in Linux code when doing XEN_PCI_OP_enable_msix can stash the -EXX in op->result and in op-