Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-09 Thread David Woodhouse
On Thu, 2017-02-09 at 11:54 +0800, Chao Gao wrote: > > Jan is right. When the assertion fails, the value of gfn is 0xfee00. > > Do you mean that is_iomem_page() is equal to direct_mmio except some > corner cases such as APIC access MFN and INVALID_MFN( any others? ) ? That was the hypothesis, an

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-09 Thread Chao Gao
On Thu, Feb 09, 2017 at 01:56:14AM -0700, Jan Beulich wrote: On 09.02.17 at 09:27, wrote: >> On Wed, Feb 08, 2017 at 10:05:38AM -0700, Jan Beulich wrote: >> On 08.02.17 at 08:31, wrote: > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, February 06, 2017 11:38 PM >>>

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-09 Thread David Woodhouse
On Thu, 2017-02-09 at 01:56 -0700, Jan Beulich wrote: > > > diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c > > index 86c71be..3d9386a 100644 > > --- a/xen/arch/x86/hvm/mtrr.c > > +++ b/xen/arch/x86/hvm/mtrr.c > > @@ -784,6 +784,8 @@ int epte_get_entry_emt(struct domain *d, unsigned

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-09 Thread Jan Beulich
>>> On 09.02.17 at 09:27, wrote: > On Wed, Feb 08, 2017 at 10:05:38AM -0700, Jan Beulich wrote: > On 08.02.17 at 08:31, wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Monday, February 06, 2017 11:38 PM >>> On 06.02.17 at 15:48, wrote: > On Mon, 2017-02-0

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-09 Thread Chao Gao
On Wed, Feb 08, 2017 at 10:05:38AM -0700, Jan Beulich wrote: On 08.02.17 at 08:31, wrote: >>> From: Jan Beulich [mailto:jbeul...@suse.com] >>> Sent: Monday, February 06, 2017 11:38 PM >>> >>> >>> On 06.02.17 at 15:48, wrote: >>> > On Mon, 2017-02-06 at 07:26 -0700, Jan Beulich wrote: >>> >

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 08:31, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, February 06, 2017 11:38 PM >> >> >>> On 06.02.17 at 15:48, wrote: >> > On Mon, 2017-02-06 at 07:26 -0700, Jan Beulich wrote: >> >> > >> >> > > >> >> > > > >> >> > > > On 06.02.17 at 14:55, wrote:

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-07 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, February 06, 2017 11:38 PM > > >>> On 06.02.17 at 15:48, wrote: > > On Mon, 2017-02-06 at 07:26 -0700, Jan Beulich wrote: > >> > > >> > > > >> > > > > >> > > > On 06.02.17 at 14:55, wrote: > >> > Switch its return type to bool to mat

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-06 Thread Jan Beulich
>>> On 06.02.17 at 15:48, wrote: > On Mon, 2017-02-06 at 07:26 -0700, Jan Beulich wrote: >> > >> > > >> > > > >> > > > On 06.02.17 at 14:55, wrote: >> > Switch its return type to bool to match its use, and simplify the >> > ARM >> > implementation slightly. >> > >> > No functional change. >>

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-06 Thread David Woodhouse
On Mon, 2017-02-06 at 07:26 -0700, Jan Beulich wrote: > > > > > > > > > > > > > On 06.02.17 at 14:55, wrote: > > Switch its return type to bool to match its use, and simplify the > > ARM > > implementation slightly. > > > > No functional change. > > > > Signed-off-by: Andrew Cooper > Reviewe

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-06 Thread Jan Beulich
>>> On 06.02.17 at 14:55, wrote: > Switch its return type to bool to match its use, and simplify the ARM > implementation slightly. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich And perhaps that's what should be used in epte_get_entry_emt() instead of !m

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-06 Thread George Dunlap
On 06/02/17 13:55, Andrew Cooper wrote: > Switch its return type to bool to match its use, and simplify the ARM > implementation slightly. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: George Dunlap > --- > CC: Jan Beulich > CC: Tim Deegan > CC: George Dunlap > CC: S

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-06 Thread Julien Grall
Hi Andrew, On 06/02/17 13:55, Andrew Cooper wrote: Switch its return type to bool to match its use, and simplify the ARM implementation slightly. No functional change. Signed-off-by: Andrew Cooper Acked-by: Julien Grall Regards, -- Julien Grall __

[Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-06 Thread Andrew Cooper
Switch its return type to bool to match its use, and simplify the ARM implementation slightly. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Tim Deegan CC: George Dunlap CC: Stefano Stabellini CC: Julien Grall --- xen/arch/arm/mm.c | 6 ++ xen/arch