On 22/09/15 11:35, Jan Beulich wrote:
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1858,15 +1858,9 @@ static void vmcs_dump(unsigned char ch)
printk("**\n");
}
-static struct keyhandler vmcs_dump_keyhandler = {
-.dia
>>> On 14.09.15 at 15:49, wrote:
> key_table doesn't need to contain 256 entries; all keys are ASCII
> which limits them to 7 bits of index, rather than 8. It can also
> become a straight array, rather than an array of pointers. struct
> keyhandler itself can become smaller simply via reordering
struct keyhandler does not contain much information, and requires a lot
of boilerplate to use. It is far more convenient to have
register_keyhandler() take each piece of information a parameter,
especially when introducing temporary debugging keyhandlers.
This in turn allows struct keyhandler its
