Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack

2016-01-19 Thread Boris Ostrovsky
On 01/18/2016 06:11 AM, David Vrabel wrote: On 15/01/16 19:43, Boris Ostrovsky wrote: struct gntdev_copy_batch is over 1300 bytes in size, we shouldn't put it on stack. Some compilers (e.g. 5.2.1) complain: drivers/xen/gntdev.c: In function ‘gntdev_ioctl_grant_copy.isra.5’: drivers/xen/gntd

Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack

2016-01-19 Thread David Vrabel
On 19/01/16 14:26, Boris Ostrovsky wrote: > On 01/18/2016 06:11 AM, David Vrabel wrote: >> On 15/01/16 19:43, Boris Ostrovsky wrote: >>> struct gntdev_copy_batch is over 1300 bytes in size, we shouldn't >>> put it on stack. >>> >>> Some compilers (e.g. 5.2.1) complain: >>> drivers/xen/gntdev.c: I

Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack

2016-01-18 Thread David Vrabel
On 15/01/16 19:43, Boris Ostrovsky wrote: > struct gntdev_copy_batch is over 1300 bytes in size, we shouldn't > put it on stack. > > Some compilers (e.g. 5.2.1) complain: > drivers/xen/gntdev.c: In function ‘gntdev_ioctl_grant_copy.isra.5’: > drivers/xen/gntdev.c:949:1: warning: the frame size o

Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack

2016-01-15 Thread Boris Ostrovsky
On 01/15/2016 02:50 PM, Andrew Cooper wrote: On 15/01/16 19:43, Boris Ostrovsky wrote: @@ -933,18 +937,20 @@ static long gntdev_ioctl_grant_copy(struct gntdev_priv *priv, void __user *u) goto out; } - ret = gntdev_grant_copy_seg(&batch, &seg, ©.segmen

Re: [Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack

2016-01-15 Thread Andrew Cooper
On 15/01/16 19:43, Boris Ostrovsky wrote: > struct gntdev_copy_batch is over 1300 bytes in size, we shouldn't > put it on stack. > > Some compilers (e.g. 5.2.1) complain: > drivers/xen/gntdev.c: In function ‘gntdev_ioctl_grant_copy.isra.5’: > drivers/xen/gntdev.c:949:1: warning: the frame size of

[Xen-devel] [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack

2016-01-15 Thread Boris Ostrovsky
struct gntdev_copy_batch is over 1300 bytes in size, we shouldn't put it on stack. Some compilers (e.g. 5.2.1) complain: drivers/xen/gntdev.c: In function ‘gntdev_ioctl_grant_copy.isra.5’: drivers/xen/gntdev.c:949:1: warning: the frame size of 1416 bytes is larger than 1024 bytes [-Wframe-larg