Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-27 Thread Anthony PERARD
On Mon, Jun 26, 2017 at 12:12:18PM -0700, Stefano Stabellini wrote: > On Mon, 26 Jun 2017, Jan Beulich wrote: > > >>> Stefano Stabellini 06/23/17 8:43 PM >>> > > >On Fri, 23 Jun 2017, Jan Beulich wrote: > > >> >>> On 22.06.17 at 20:52, wrote: > > >> > I am happy to write the code and/or the commi

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-26 Thread Stefano Stabellini
On Mon, 26 Jun 2017, Jan Beulich wrote: > >>> Stefano Stabellini 06/23/17 8:43 PM >>> > >On Fri, 23 Jun 2017, Jan Beulich wrote: > >> >>> On 22.06.17 at 20:52, wrote: > >> > I am happy to write the code and/or the commit message. Would a simple > >> > cast like below work to fix the security issu

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-25 Thread Jan Beulich
>>> Stefano Stabellini 06/23/17 8:43 PM >>> >On Fri, 23 Jun 2017, Jan Beulich wrote: >> >>> On 22.06.17 at 20:52, wrote: >> > I am happy to write the code and/or the commit message. Would a simple >> > cast like below work to fix the security issue? >> >> I suppose so, but you do realize that th

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-23 Thread Stefano Stabellini
On Fri, 23 Jun 2017, Jan Beulich wrote: > >>> On 22.06.17 at 20:52, wrote: > > On Thu, 22 Jun 2017, Jan Beulich wrote: > >> >>> On 21.06.17 at 20:46, wrote: > >> > On Wed, 21 Jun 2017, Jan Beulich wrote: > >> >> >>> On 20.06.17 at 23:48, wrote: > >> >> > On Tue, 20 Jun 2017, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-23 Thread Jan Beulich
>>> On 22.06.17 at 20:52, wrote: > On Thu, 22 Jun 2017, Jan Beulich wrote: >> >>> On 21.06.17 at 20:46, wrote: >> > On Wed, 21 Jun 2017, Jan Beulich wrote: >> >> >>> On 20.06.17 at 23:48, wrote: >> >> > On Tue, 20 Jun 2017, Jan Beulich wrote: >> >> >> @@ -36,13 +33,7 @@ struct blkif_x86_32_reque

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-22 Thread Stefano Stabellini
On Thu, 22 Jun 2017, Jan Beulich wrote: > >>> On 21.06.17 at 20:46, wrote: > > On Wed, 21 Jun 2017, Jan Beulich wrote: > >> >>> On 20.06.17 at 23:48, wrote: > >> > On Tue, 20 Jun 2017, Jan Beulich wrote: > >> >> @@ -36,13 +33,7 @@ struct blkif_x86_32_request_discard { > >> >> blkif_sector_t

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-21 Thread Jan Beulich
>>> On 21.06.17 at 20:46, wrote: > On Wed, 21 Jun 2017, Jan Beulich wrote: >> >>> On 20.06.17 at 23:48, wrote: >> > On Tue, 20 Jun 2017, Jan Beulich wrote: >> >> @@ -36,13 +33,7 @@ struct blkif_x86_32_request_discard { >> >> blkif_sector_t sector_number;/* start sector idx on disk (r/w

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-21 Thread Stefano Stabellini
On Wed, 21 Jun 2017, Jan Beulich wrote: > >>> On 20.06.17 at 23:48, wrote: > > On Tue, 20 Jun 2017, Jan Beulich wrote: > >> @@ -36,13 +33,7 @@ struct blkif_x86_32_request_discard { > >> blkif_sector_t sector_number;/* start sector idx on disk (r/w > >> only) */ > >> uint64_t

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-20 Thread Jan Beulich
>>> On 20.06.17 at 23:48, wrote: > On Tue, 20 Jun 2017, Jan Beulich wrote: >> @@ -36,13 +33,7 @@ struct blkif_x86_32_request_discard { >> blkif_sector_t sector_number;/* start sector idx on disk (r/w only) >> */ >> uint64_t nr_sectors; /* # of contiguous sectors to disc

Re: [Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2017, Jan Beulich wrote: > Rather than constructing a local structure instance on the stack, fill > the fields directly on the shared ring, just like other (Linux) > backends do. Build on the fact that all response structure flavors are > actually identical (the old code did make thi

[Xen-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-20 Thread Jan Beulich
Rather than constructing a local structure instance on the stack, fill the fields directly on the shared ring, just like other (Linux) backends do. Build on the fact that all response structure flavors are actually identical (the old code did make this assumption too). This is XSA-216. Reported b