Re: [Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Andrew Cooper
On 14/12/16 14:49, Jan Beulich wrote: On 14.12.16 at 14:47, wrote: >> On 14/12/16 13:39, Jan Beulich wrote: >> On 14.12.16 at 14:28, wrote: On 14/12/16 13:18, Jan Beulich wrote: On 14.12.16 at 13:36, wrote: >> On 14/12/16 09:37, Jan Beulich wrote: >>> @@ -5205,6 +5

Re: [Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Jan Beulich
>>> On 14.12.16 at 14:47, wrote: > On 14/12/16 13:39, Jan Beulich wrote: > On 14.12.16 at 14:28, wrote: >>> On 14/12/16 13:18, Jan Beulich wrote: >>> On 14.12.16 at 13:36, wrote: > On 14/12/16 09:37, Jan Beulich wrote: >> @@ -5205,6 +5206,44 @@ x86_emulate( >> }

Re: [Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Andrew Cooper
On 14/12/16 13:39, Jan Beulich wrote: On 14.12.16 at 14:28, wrote: >> On 14/12/16 13:18, Jan Beulich wrote: >> On 14.12.16 at 13:36, wrote: On 14/12/16 09:37, Jan Beulich wrote: > @@ -5205,6 +5206,44 @@ x86_emulate( > } > break; > > +case

Re: [Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Jan Beulich
>>> On 14.12.16 at 14:28, wrote: > On 14/12/16 13:18, Jan Beulich wrote: > On 14.12.16 at 13:36, wrote: >>> On 14/12/16 09:37, Jan Beulich wrote: @@ -5205,6 +5206,44 @@ x86_emulate( } break; +case X86EMUL_OPC_F3(0x0f, 0xae): /* Grp15 */ +

Re: [Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Andrew Cooper
On 14/12/16 13:18, Jan Beulich wrote: On 14.12.16 at 13:36, wrote: >> On 14/12/16 09:37, Jan Beulich wrote: >>> @@ -5205,6 +5206,44 @@ x86_emulate( >>> } >>> break; >>> >>> +case X86EMUL_OPC_F3(0x0f, 0xae): /* Grp15 */ >>> +{ >>> +unsigned long cr4; >>> + >

Re: [Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Jan Beulich
>>> On 14.12.16 at 13:36, wrote: > On 14/12/16 09:37, Jan Beulich wrote: >> @@ -5205,6 +5206,44 @@ x86_emulate( >> } >> break; >> >> +case X86EMUL_OPC_F3(0x0f, 0xae): /* Grp15 */ >> +{ >> +unsigned long cr4; >> + >> +fail_if(modrm_mod != 3); > > This sh

Re: [Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Andrew Cooper
On 14/12/16 09:37, Jan Beulich wrote: > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -432,6 +432,7 @@ typedef union { > #define CR4_OSFXSR (1<<9) > #define CR4_OSXMMEXCPT (1<<10) > #define CR4_UMIP (1<<

[Xen-devel] [PATCH] x86emul: support {RD,WR}{F,G}SBASE

2016-12-14 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -432,6 +432,7 @@ typedef union { #define CR4_OSFXSR (1<<9) #define CR4_OSXMMEXCPT (1<<10) #define CR4_UMIP (1<<11) +#define CR4_FSGSBASE (1<<16) #define CR4_OSXS