Re: [Xen-devel] [PATCH] x86emul: simplify SHLD/SHRD handling

2017-06-23 Thread Andrew Cooper
On 20/06/17 07:20, Jan Beulich wrote: > First of all there's no point considering the "shift == width" case, > when immediately before that check we mask "shift" by "width - 1". And > then truncate_word() use can be reduced too: dst.val, as obtained by > generic operand fetching code, is already su

[Xen-devel] [PATCH] x86emul: simplify SHLD/SHRD handling

2017-06-19 Thread Jan Beulich
First of all there's no point considering the "shift == width" case, when immediately before that check we mask "shift" by "width - 1". And then truncate_word() use can be reduced too: dst.val, as obtained by generic operand fetching code, is already suitably truncated, and its use can also be made