Re: [Xen-devel] [PATCH] x86emul: relax asm() constraints

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 14:39, wrote: > On 15/02/16 12:06, Jan Beulich wrote: >> @@ -4542,9 +4542,10 @@ x86_emulate( >> >> case 0xbc: /* bsf or tzcnt */ { >> bool_t zf; >> -asm ( "bsf %2,%0; setz %b1" >> + >> +asm ( "bsf %2,%0; setz %1" >>: "=r" (dst.val)

Re: [Xen-devel] [PATCH] x86emul: relax asm() constraints

2016-02-15 Thread Andrew Cooper
On 15/02/16 12:06, Jan Beulich wrote: > Let's give the compiler as much liberty in picking instruction operands > as possible. Also drop unnecessary size modifiers when the correct size > can already be derived from the asm() operands. Finally also drop an > "unsigned" from idiv_dbl()'s second para

[Xen-devel] [PATCH] x86emul: relax asm() constraints

2016-02-15 Thread Jan Beulich
Let's give the compiler as much liberty in picking instruction operands as possible. Also drop unnecessary size modifiers when the correct size can already be derived from the asm() operands. Finally also drop an "unsigned" from idiv_dbl()'s second parameter, allowing a cast to be eliminated. Sign