Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 17:03, wrote: > On 12/06/17 15:06, Jan Beulich wrote: > On 12.06.17 at 14:41, wrote: >>> On 12/06/17 07:23, Jan Beulich wrote: As a side note, I'm removing these here since the further SIMD emulation patches I have ready, but would prefer to post only once 4.

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-12 Thread Andrew Cooper
On 12/06/17 15:06, Jan Beulich wrote: On 12.06.17 at 14:41, wrote: >> On 12/06/17 07:23, Jan Beulich wrote: >> On 09.06.17 at 19:50, wrote: On 08/06/17 16:49, Jan Beulich wrote: > Drop a redundant input constraint, correct a comment, and (re)move > fix.insn_bytes adjustments

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-12 Thread Jan Beulich
>>> On 12.06.17 at 14:41, wrote: > On 12/06/17 07:23, Jan Beulich wrote: > On 09.06.17 at 19:50, wrote: >>> On 08/06/17 16:49, Jan Beulich wrote: Drop a redundant input constraint, correct a comment, and (re)move fix.insn_bytes adjustments (these aren't needed for custom stub i

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-12 Thread Andrew Cooper
On 12/06/17 07:23, Jan Beulich wrote: On 09.06.17 at 19:50, wrote: >> On 08/06/17 16:49, Jan Beulich wrote: >>> Drop a redundant input constraint, correct a comment, and (re)move >>> fix.insn_bytes adjustments (these aren't needed for custom stub >>> invocations when the instruction placed in

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-11 Thread Jan Beulich
>>> On 09.06.17 at 19:50, wrote: > On 08/06/17 16:49, Jan Beulich wrote: >> Drop a redundant input constraint, correct a comment, and (re)move >> fix.insn_bytes adjustments (these aren't needed for custom stub >> invocations when the instruction placed in the stub can't raise #XF) > > I'm not sur

Re: [Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-09 Thread Andrew Cooper
On 08/06/17 16:49, Jan Beulich wrote: > Drop a redundant input constraint, correct a comment, and (re)move > fix.insn_bytes adjustments (these aren't needed for custom stub > invocations when the instruction placed in the stub can't raise #XF) I'm not sure these are wise to remove. Even if we don

[Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-08 Thread Jan Beulich
Drop a redundant input constraint, correct a comment, and (re)move fix.insn_bytes adjustments (these aren't needed for custom stub invocations when the instruction placed in the stub can't raise #XF) plus a corresponding check_xmm_exn() invocation. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x