Re: [Xen-devel] [PATCH] x86emul: constify write_segment() register pointer

2016-12-08 Thread Andrew Cooper
On 08/12/16 11:53, Jan Beulich wrote: > Since I stumbled across this while looking for further constification > opportunities, also correct the insn_fetch() related comment. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper , although a suggestion about the wording. > --- > I would have

Re: [Xen-devel] [PATCH] x86emul: constify write_segment() register pointer

2016-12-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 December 2016 11:53 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > > Subject: [PATCH] x86emul: constify write_segment() register pointer > > Since I stumbled across this while looking for further constif

[Xen-devel] [PATCH] x86emul: constify write_segment() register pointer

2016-12-08 Thread Jan Beulich
Since I stumbled across this while looking for further constification opportunities, also correct the insn_fetch() related comment. Signed-off-by: Jan Beulich --- I would have wanted to also constify the pointers passed to .write(), .cmpxchg(), and .rep_stos(), but that doesn't work (not only) be